Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.4 Support: Errors and their output may be different #2902

Open
kaylareopelle opened this issue Oct 8, 2024 · 1 comment
Open

Ruby 3.4 Support: Errors and their output may be different #2902

kaylareopelle opened this issue Oct 8, 2024 · 1 comment

Comments

@kaylareopelle
Copy link
Contributor

kaylareopelle commented Oct 8, 2024

In the config_file_loading multiverse suite, the test test_warning_logged_when_config_file_erb_error fails because the file name and line number are no longer included in the error output. In addition, the error class has also changed.

Ruby 3.3.1:

** [NewRelic] FATAL : Failed ERB processing configuration file. This is typically caused by a Ruby error in <% %> templating blocks in your newrelic.yml file.
** [NewRelic] FATAL : (erb):4: syntax error, unexpected local variable or method, expecting '('
; _erbout.<<(( this is not ruby ).to_s); _erbout

Ruby 3.4.0-preview2:

[2024-10-08 16:38:39 -0700 C02F23LMMD6P (16577)] ERROR : Failed ERB processing configuration file. This is typically caused by a Ruby error in <% %> templating blocks in your newrelic.yml file.
[2024-10-08 16:38:39 -0700 C02F23LMMD6P (16577)] ERROR : NameError: undefined local variable or method 'ruby' for an instance of NewRelic::Agent::Configuration::YamlSource

In addition to fixing the test, we may want to take a closer look at our New Relic agent log error output and errors inbox behavior to see if there are unintended changes that might compromise the customer's experience.

The config_file_loading suite is currently disabled for Ruby 3.4.0-preview2. It will need to be manually re-enabled for testing.

@workato-integration
Copy link

@kaylareopelle kaylareopelle added oct-dec qtr Possible FY Q3 candidate core technology labels Oct 8, 2024
@kaylareopelle kaylareopelle moved this from Triage to In Quarter in Ruby Engineering Board Oct 8, 2024
@kaylareopelle kaylareopelle moved this from In Quarter to Triage in Ruby Engineering Board Oct 8, 2024
@kford-newrelic kford-newrelic moved this from Triage to In Quarter in Ruby Engineering Board Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Quarter
Development

No branches or pull requests

3 participants