Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The agent reports non-fatal errors as fatal #2941

Open
fallwith opened this issue Nov 7, 2024 · 1 comment
Open

The agent reports non-fatal errors as fatal #2941

fallwith opened this issue Nov 7, 2024 · 1 comment
Labels

Comments

@fallwith
Copy link
Contributor

fallwith commented Nov 7, 2024

Conceivably, a user might see a "FATAL" message written to a log or stdout and assume that the agent has halted, crashed, or otherwise exited.

In the Ruby agent, however, "FATAL" is used to convey that there is a high likelihood of normal behavior being interrupted or corrupted but the agent will still do its best to continue.

For example, invalid YAML syntax found in the newrelic.yml config file will produce "FATAL" messages but the agent will continue to operate and source its configuration from other sources (defaults, environment variables).

On a case-by-case basis, we should either have each "FATAL" message accompanied by an effort to halt the agent or downgrade the message severity to "ERROR".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

1 participant