From 654ead123d3406029c0d531a2ada81681393d319 Mon Sep 17 00:00:00 2001 From: Kayla Reopelle Date: Thu, 21 Nov 2024 12:45:12 -0800 Subject: [PATCH 1/3] try putting view component in its own group --- test/multiverse/lib/multiverse/runner.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/test/multiverse/lib/multiverse/runner.rb b/test/multiverse/lib/multiverse/runner.rb index a7470ed51e..8bb5e640e3 100644 --- a/test/multiverse/lib/multiverse/runner.rb +++ b/test/multiverse/lib/multiverse/runner.rb @@ -109,6 +109,7 @@ def execute_suites(filter, opts) 'httpclients' => %w[async_http curb excon httpclient], 'httpclients_2' => %w[typhoeus net_http httprb ethon httpx], 'infinite_tracing' => %w[infinite_tracing], + 'view_component' => %w[view_component] 'rest' => [] # Specially handled below } From 9a9eed85a9fcc39c5c749ae5dca5a80c4f52bac0 Mon Sep 17 00:00:00 2001 From: Kayla Reopelle Date: Thu, 21 Nov 2024 12:47:00 -0800 Subject: [PATCH 2/3] comma for array --- test/multiverse/lib/multiverse/runner.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/multiverse/lib/multiverse/runner.rb b/test/multiverse/lib/multiverse/runner.rb index 8bb5e640e3..51eab35a2b 100644 --- a/test/multiverse/lib/multiverse/runner.rb +++ b/test/multiverse/lib/multiverse/runner.rb @@ -109,7 +109,7 @@ def execute_suites(filter, opts) 'httpclients' => %w[async_http curb excon httpclient], 'httpclients_2' => %w[typhoeus net_http httprb ethon httpx], 'infinite_tracing' => %w[infinite_tracing], - 'view_component' => %w[view_component] + 'view_component' => %w[view_component], 'rest' => [] # Specially handled below } From d40e3c958b3e5b544107e858e9da51a721655744 Mon Sep 17 00:00:00 2001 From: Kayla Reopelle Date: Thu, 21 Nov 2024 12:55:10 -0800 Subject: [PATCH 3/3] add it to ci --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 41a061873a..7f22d59050 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -216,7 +216,7 @@ jobs: strategy: fail-fast: false matrix: - multiverse: [agent, ai, background, background_2, kafka, database, frameworks, httpclients, httpclients_2, rails, rest] + multiverse: [agent, ai, background, background_2, kafka, database, frameworks, httpclients, httpclients_2, rails, rest, view_component] ruby-version: [2.4.10, 3.3.6] steps: