Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Fargate fetcher testable #136

Open
kang-makes opened this issue Jul 5, 2022 · 0 comments
Open

Make Fargate fetcher testable #136

kang-makes opened this issue Jul 5, 2022 · 0 comments
Labels
priority/long-term Important over the long term, but may not be staffed and/or may need multiple releases to complete. test Categorizes issue or PR as related to a consistently or frequently failing test. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@kang-makes
Copy link
Contributor

Is your feature request related to a problem?

PR #135 make us realise that there is no test in the Fargate fetcher. When we did that PR we realised that we cannot do the code testable because of the way it is coded.

Feature Description

We should refactor the Fargate fetcher so we add an HTTP client while instancing the scraper/fetcher so we can mock the server among other changes to make tests possible)

Priority

Nice to Have
@kang-makes kang-makes mentioned this issue Jul 5, 2022
Merged
@carlossscastro carlossscastro added priority/long-term Important over the long term, but may not be staffed and/or may need multiple releases to complete. test Categorizes issue or PR as related to a consistently or frequently failing test. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/long-term Important over the long term, but may not be staffed and/or may need multiple releases to complete. test Categorizes issue or PR as related to a consistently or frequently failing test. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlossscastro @kang-makes