Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated by NC18's locking feature? #55

Open
putt1ck opened this issue Jan 21, 2020 · 3 comments
Open

Deprecated by NC18's locking feature? #55

putt1ck opened this issue Jan 21, 2020 · 3 comments

Comments

@putt1ck
Copy link
Member

putt1ck commented Jan 21, 2020

NC18 "hub" has been announced as including file locking, presumably using https://github.com/nextcloud/files_lock (not clear, but judging by the committers to that app). If it covers all the use cases of W2G2, then W2G2 should be flagged as deprecated and maybe not enabled for NC18.

@DBJRdev
Copy link

DBJRdev commented Jan 21, 2020

Well, open source is also about choice, so I wouldn't automatically assume W2G2 (itself being a fork) should be deprecated. As far as I understood, W2G2 currently has more visible options on the admin side: admins can see which files are locked and also unlock them directly from the backend.

I'm grateful for what this app here has offered for the past years. Yet we will most probably make the switch with our NC instances to NC's locking feature, because of the chances for WebDAV locking.

@putt1ck
Copy link
Member Author

putt1ck commented Jan 21, 2020

Well, as the people sponsoring development of W2G2 we'd tend to assume we'd switch to the NC one as it is likely to get better integration - unless it cannot/will not do something users want. But we'd also assume that the NC one will be a default app, which means new deployments of NC are unlikely to find let alone deploy W2G2; even less incentive for us to continue development.

And of course anyone who does want to continue development can always fork it :)

@nursoda
Copy link

nursoda commented Jan 26, 2020

I'm also here to find some facts to decide upon whether pseudo locks are helpful at all and if so which to use.

They seem to use the same table since I tested with both installed: Locking a file using one of them results in both UIs showing the lock after a page reload. So both basically do the same thing, and seem to be compatible to a certain extent. files_lock seems to have a timer to unlock W2G2 doesn't have. Since W2G2 seems pretty advanced (admin UI, folder feature), I'm curious why NC team decided to implement from scratch instead of forking or just improving it.

Anyway, locks set in the WebUI are NOT seen outside the WebUI, not even in the beta android app. As long as this is the case, I won't use either since my usecases are files on the PC using NC Sync App, and the NC mobile app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants