Using latest pip installed version of requests breaks library completely

[eads]

using requests==1.0.4, the get(...) method passes an unexpected param called config. Downgrading to requests 0.13.2 (the last version I used which I knew worked with the library) fixes the problem. Seems like requests has changed it's allowed parameters since the summer.

[andymboyle]

I believe I have fixed this.

[eads]

I fixed it, but I doubt the fixes are backwards compatible to old Requests versions. Will we want that, or can we call it fixed?

[rnagle]

I think we can call it fixed as long as the tests pass.

[eads]

Do you know how to run the tests? Do we just need to set environment
variables for the test run?

On Wed, Jan 9, 2013 at 2:52 PM, Ryan Nagle [email protected] wrote:

I think we can call it fixed as long as the tests pass.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-12066002.

David Eads - 773.354.2285
News applications developer, Chicago Tribune (
http://www.chicagotribune.com/news/data/)
Founder, FreeGeek Chicago (http://freegeekchicago.org)

“The awful thing about life is this: everyone has their reasons.” -- Jean
Renoir

[rnagle]

Make sure you have P2P_API_URL and P2P_API_KEY env vars set. Create a new virtualenv for the p2p module and install the module in it. Then run the tests: cd path/to/p2p-python; ./p2p/tests.py