Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize, simplify and clean up fixtures #913

Open
gonzaponte opened this issue Oct 30, 2024 · 0 comments
Open

Reorganize, simplify and clean up fixtures #913

gonzaponte opened this issue Oct 30, 2024 · 0 comments
Labels
easy good first issue Issues for people willing to get into IC help wanted testing

Comments

@gonzaponte
Copy link
Collaborator

We use many fixtures. Most of them are thrown into invisible_cities/conftest.py without thinking much. Let's reorganize them following the following logic:

  • If they are used only in one file, move them to that file
  • If they are used only in one folder, move them to the conftest.py file in that folder
  • Otherwise, keep them in invisible_cities/conftest.py

Moreover, some of those fixtures are monstrous. Let's try to simplify them or replace them with test files whenever possible to keep things readable.

@gonzaponte gonzaponte added help wanted good first issue Issues for people willing to get into IC easy testing labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy good first issue Issues for people willing to get into IC help wanted testing
Projects
None yet
Development

No branches or pull requests

1 participant