Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometry testing #82

Open
jmunozv opened this issue Feb 5, 2021 · 2 comments
Open

Geometry testing #82

jmunozv opened this issue Feb 5, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@jmunozv
Copy link
Collaborator

jmunozv commented Feb 5, 2021

The idea is to have a couple of automatic tests:

  1. Check that the volumes / masses of all the different volumes in our detectors have the expected value.
  2. Check that there are no overlaps between the volumes of a detector.
@jmunozv jmunozv added enhancement New feature or request good first issue Good for newcomers labels Feb 5, 2021
@paolafer paolafer removed the good first issue Good for newcomers label Feb 25, 2022
@paolafer
Copy link
Contributor

paolafer commented Jan 9, 2024

Point 2 is being addressed now in PR #231.

@paolafer
Copy link
Contributor

paolafer commented May 2, 2024

Point 2 is being addressed now in PR #231.

Addressed and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paolafer @jmunozv