From e5fc9aa76b23b9c3d85721cbad55103149dc3d1d Mon Sep 17 00:00:00 2001 From: Gonzalo Martinez Lema Date: Mon, 22 Apr 2024 18:08:22 +0200 Subject: [PATCH 1/3] Warn users of deprecated classes - ELLookupTable - RadiusDependentDriftField - WavelengthShifting --- source/physics/ELLookupTable.cc | 4 ++++ source/physics/ELLookupTable.h | 4 ++++ source/physics/RadiusDependentDriftField.cc | 5 +++++ source/physics/RadiusDependentDriftField.h | 5 +++++ source/physics/WavelengthShifting.cc | 4 ++++ source/physics/WavelengthShifting.h | 4 ++++ 6 files changed, 26 insertions(+) diff --git a/source/physics/ELLookupTable.cc b/source/physics/ELLookupTable.cc index 3651350185..6a1ffd8daf 100644 --- a/source/physics/ELLookupTable.cc +++ b/source/physics/ELLookupTable.cc @@ -3,6 +3,10 @@ // // This class describes the generation of the EL light. // +// ****************************** WARNING ******************************* +// ******************* This class has been deprecated ******************* +// ********************************************************************** +// // The NEXT Collaboration // ---------------------------------------------------------------------------- diff --git a/source/physics/ELLookupTable.h b/source/physics/ELLookupTable.h index 3fe0cd9014..b20f53f8d9 100644 --- a/source/physics/ELLookupTable.h +++ b/source/physics/ELLookupTable.h @@ -3,6 +3,10 @@ // // This class describes the generation of the EL light. // +// ****************************** WARNING ******************************* +// ******************* This class has been deprecated ******************* +// ********************************************************************** +// // The NEXT Collaboration // ---------------------------------------------------------------------------- diff --git a/source/physics/RadiusDependentDriftField.cc b/source/physics/RadiusDependentDriftField.cc index 42d4f01608..569c66a987 100644 --- a/source/physics/RadiusDependentDriftField.cc +++ b/source/physics/RadiusDependentDriftField.cc @@ -3,6 +3,11 @@ // // Drift field varying with radial coordinate. // +// +// ****************************** WARNING ******************************* +// ******************* This class has been deprecated ******************* +// ********************************************************************** +// // The NEXT Collaboration // ---------------------------------------------------------------------------- diff --git a/source/physics/RadiusDependentDriftField.h b/source/physics/RadiusDependentDriftField.h index f6e7fae590..a96afaa2de 100644 --- a/source/physics/RadiusDependentDriftField.h +++ b/source/physics/RadiusDependentDriftField.h @@ -3,6 +3,11 @@ // // Drift field varying with radial coordinate. // +// +// ****************************** WARNING ******************************* +// ******************* This class has been deprecated ******************* +// ********************************************************************** +// // The NEXT Collaboration // ---------------------------------------------------------------------------- diff --git a/source/physics/WavelengthShifting.cc b/source/physics/WavelengthShifting.cc index 99a067216a..8bd1be3f06 100644 --- a/source/physics/WavelengthShifting.cc +++ b/source/physics/WavelengthShifting.cc @@ -6,6 +6,10 @@ // from a wls_absorption length property but through a probability property, // thus independent from the material thickness. // +// ****************************** WARNING ******************************* +// ******************* This class has been deprecated ******************* +// ********************************************************************** +// // The NEXT Collaboration // ---------------------------------------------------------------------------- diff --git a/source/physics/WavelengthShifting.h b/source/physics/WavelengthShifting.h index eafb25ad4f..876ea5d0af 100644 --- a/source/physics/WavelengthShifting.h +++ b/source/physics/WavelengthShifting.h @@ -6,6 +6,10 @@ // from a wls_absorption length property but through a probability property, // thus independent from the material thickness. // +// ****************************** WARNING ******************************* +// ******************* This class has been deprecated ******************* +// ********************************************************************** +// // The NEXT Collaboration // ---------------------------------------------------------------------------- From ab6517f164b2ffc0ab437635bd01da5b8d1c4f6c Mon Sep 17 00:00:00 2001 From: Gonzalo Martinez Lema Date: Tue, 23 Apr 2024 15:20:56 +0200 Subject: [PATCH 2/3] Remove wavelength shifting from the nexus physics list --- source/physics_lists/NexusPhysics.cc | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/source/physics_lists/NexusPhysics.cc b/source/physics_lists/NexusPhysics.cc index 6fe28f9926..eb92e13ce6 100644 --- a/source/physics_lists/NexusPhysics.cc +++ b/source/physics_lists/NexusPhysics.cc @@ -12,7 +12,6 @@ #include "IonizationClustering.h" #include "IonizationDrift.h" #include "Electroluminescence.h" -#include "WavelengthShifting.h" #include "OpPhotoelectricEffect.h" #include @@ -75,15 +74,6 @@ namespace nexus { { G4ProcessManager* pmanager = 0; - // Add our own wavelength shifting process for the optical photon - pmanager = G4OpticalPhoton::Definition()->GetProcessManager(); - if (!pmanager) { - G4Exception("[NexusPhysics]", "ConstructProcess()", FatalException, - "G4OpticalPhoton without a process manager."); - } - WavelengthShifting* wls = new WavelengthShifting(); - pmanager->AddDiscreteProcess(wls); - pmanager = IonizationElectron::Definition()->GetProcessManager(); if (!pmanager) { G4Exception("[NexusPhysics]", "ConstructProcess()", FatalException, From 43b9af7394cfeeefe65954601b38202fbb375933 Mon Sep 17 00:00:00 2001 From: Gonzalo Martinez Lema Date: Wed, 24 Apr 2024 11:06:38 +0200 Subject: [PATCH 3/3] Fix comment in RadiusDependentDriftField --- source/physics/RadiusDependentDriftField.cc | 3 +-- source/physics/RadiusDependentDriftField.h | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/source/physics/RadiusDependentDriftField.cc b/source/physics/RadiusDependentDriftField.cc index 569c66a987..e309ef1291 100644 --- a/source/physics/RadiusDependentDriftField.cc +++ b/source/physics/RadiusDependentDriftField.cc @@ -3,9 +3,8 @@ // // Drift field varying with radial coordinate. // -// // ****************************** WARNING ******************************* -// ******************* This class has been deprecated ******************* +// ***************** This class has not been implemented **************** // ********************************************************************** // // The NEXT Collaboration diff --git a/source/physics/RadiusDependentDriftField.h b/source/physics/RadiusDependentDriftField.h index a96afaa2de..8414c0420b 100644 --- a/source/physics/RadiusDependentDriftField.h +++ b/source/physics/RadiusDependentDriftField.h @@ -3,9 +3,8 @@ // // Drift field varying with radial coordinate. // -// // ****************************** WARNING ******************************* -// ******************* This class has been deprecated ******************* +// ***************** This class has not been implemented **************** // ********************************************************************** // // The NEXT Collaboration