Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rails-4.2.5.1でenju_leaf-1.1が動作しない #1141

Closed
1 task done
nabeta opened this issue Jan 30, 2016 · 13 comments
Closed
1 task done

rails-4.2.5.1でenju_leaf-1.1が動作しない #1141

nabeta opened this issue Jan 30, 2016 · 13 comments
Milestone

Comments

@nabeta
Copy link
Member

nabeta commented Jan 30, 2016

  • マニュアル修正が必要ないことを確認

OSX 10.11とUbuntu 14.04の両方で確認。以下がエラーログ。
また、rails-4.2.5に戻すと動作することも確認。

mobylette (3.5) lib/mobylette/resolvers/chained_fallback_resolver.rb:42:in `find_templates'
actionview (4.2.5.1) lib/action_view/template/resolver.rb:116:in `block in find_all'
actionview (4.2.5.1) lib/action_view/template/resolver.rb:152:in `block in cached'
actionview (4.2.5.1) lib/action_view/template/resolver.rb:63:in `cache'
actionview (4.2.5.1) lib/action_view/template/resolver.rb:151:in `cached'
actionview (4.2.5.1) lib/action_view/template/resolver.rb:115:in `find_all'
actionview (4.2.5.1) lib/action_view/path_set.rb:70:in `block (2 levels) in _find_all'
actionview (4.2.5.1) lib/action_view/path_set.rb:66:in `each'
actionview (4.2.5.1) lib/action_view/path_set.rb:66:in `block in _find_all'
actionview (4.2.5.1) lib/action_view/path_set.rb:65:in `each'
actionview (4.2.5.1) lib/action_view/path_set.rb:65:in `_find_all'
actionview (4.2.5.1) lib/action_view/path_set.rb:54:in `find_all'
actionview (4.2.5.1) lib/action_view/lookup_context.rb:130:in `find_all'
actionview (4.2.5.1) lib/action_view/layouts.rb:321:in `_layout'
actionview (4.2.5.1) lib/action_view/layouts.rb:409:in `_default_layout'
actionview (4.2.5.1) lib/action_view/layouts.rb:386:in `block in _layout_for_option'
actionview (4.2.5.1) lib/action_view/renderer/template_renderer.rb:93:in `resolve_layout'
actionview (4.2.5.1) lib/action_view/renderer/template_renderer.rb:76:in `block in find_layout'
actionview (4.2.5.1) lib/action_view/lookup_context.rb:246:in `with_layout_format'
actionview (4.2.5.1) lib/action_view/renderer/abstract_renderer.rb:18:in `with_layout_format'
actionview (4.2.5.1) lib/action_view/renderer/template_renderer.rb:76:in `find_layout'
actionview (4.2.5.1) lib/action_view/renderer/template_renderer.rb:60:in `render_with_layout'
actionview (4.2.5.1) lib/action_view/renderer/template_renderer.rb:52:in `render_template'
actionview (4.2.5.1) lib/action_view/renderer/template_renderer.rb:14:in `render'
actionview (4.2.5.1) lib/action_view/renderer/renderer.rb:42:in `render_template'
actionview (4.2.5.1) lib/action_view/renderer/renderer.rb:23:in `render'
actionview (4.2.5.1) lib/action_view/rendering.rb:100:in `_render_template'
actionpack (4.2.5.1) lib/action_controller/metal/streaming.rb:217:in `_render_template'
actionview (4.2.5.1) lib/action_view/rendering.rb:83:in `render_to_body'
actionpack (4.2.5.1) lib/action_controller/metal/rendering.rb:32:in `render_to_body'
actionpack (4.2.5.1) lib/action_controller/metal/renderers.rb:37:in `render_to_body'
actionpack (4.2.5.1) lib/abstract_controller/rendering.rb:25:in `render'
actionpack (4.2.5.1) lib/action_controller/metal/rendering.rb:16:in `render'
actionpack (4.2.5.1) lib/action_controller/metal/instrumentation.rb:44:in `block (2 levels) in render'
activesupport (4.2.5.1) lib/active_support/core_ext/benchmark.rb:12:in `block in ms'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/2.3.0/benchmark.rb:308:in `realtime'
activesupport (4.2.5.1) lib/active_support/core_ext/benchmark.rb:12:in `ms'
actionpack (4.2.5.1) lib/action_controller/metal/instrumentation.rb:44:in `block in render'
actionpack (4.2.5.1) lib/action_controller/metal/instrumentation.rb:87:in `cleanup_view_runtime'
activerecord (4.2.5.1) lib/active_record/railties/controller_runtime.rb:25:in `cleanup_view_runtime'
sunspot_rails (2.2.0) lib/sunspot/rails/railties/controller_runtime.rb:15:in `cleanup_view_runtime'
actionpack (4.2.5.1) lib/action_controller/metal/instrumentation.rb:43:in `render'
actionpack (4.2.5.1) lib/action_controller/metal/mime_responds.rb:217:in `respond_to'
/Users/kosuke/enju_leaf/app/controllers/page_controller.rb:41:in `index'
actionpack (4.2.5.1) lib/action_controller/metal/implicit_render.rb:4:in `send_action'
actionpack (4.2.5.1) lib/abstract_controller/base.rb:198:in `process_action'
actionpack (4.2.5.1) lib/action_controller/metal/rendering.rb:10:in `process_action'
actionpack (4.2.5.1) lib/abstract_controller/callbacks.rb:20:in `block in process_action'
activesupport (4.2.5.1) lib/active_support/callbacks.rb:117:in `call'
activesupport (4.2.5.1) lib/active_support/callbacks.rb:555:in `block (2 levels) in compile'
activesupport (4.2.5.1) lib/active_support/callbacks.rb:505:in `call'
activesupport (4.2.5.1) lib/active_support/callbacks.rb:92:in `__run_callbacks__'
activesupport (4.2.5.1) lib/active_support/callbacks.rb:778:in `_run_process_action_callbacks'
activesupport (4.2.5.1) lib/active_support/callbacks.rb:81:in `run_callbacks'
actionpack (4.2.5.1) lib/abstract_controller/callbacks.rb:19:in `process_action'
actionpack (4.2.5.1) lib/action_controller/metal/rescue.rb:29:in `process_action'
actionpack (4.2.5.1) lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
activesupport (4.2.5.1) lib/active_support/notifications.rb:164:in `block in instrument'
activesupport (4.2.5.1) lib/active_support/notifications/instrumenter.rb:20:in `instrument'
activesupport (4.2.5.1) lib/active_support/notifications.rb:164:in `instrument'
actionpack (4.2.5.1) lib/action_controller/metal/instrumentation.rb:30:in `process_action'
actionpack (4.2.5.1) lib/action_controller/metal/params_wrapper.rb:250:in `process_action'
activerecord (4.2.5.1) lib/active_record/railties/controller_runtime.rb:18:in `process_action'
actionpack (4.2.5.1) lib/abstract_controller/base.rb:137:in `process'
actionview (4.2.5.1) lib/action_view/rendering.rb:30:in `process'
actionpack (4.2.5.1) lib/action_controller/metal.rb:196:in `dispatch'
actionpack (4.2.5.1) lib/action_controller/metal/rack_delegation.rb:13:in `dispatch'
actionpack (4.2.5.1) lib/action_controller/metal.rb:237:in `block in action'
actionpack (4.2.5.1) lib/action_dispatch/routing/route_set.rb:74:in `dispatch'
actionpack (4.2.5.1) lib/action_dispatch/routing/route_set.rb:43:in `serve'
actionpack (4.2.5.1) lib/action_dispatch/journey/router.rb:43:in `block in serve'
actionpack (4.2.5.1) lib/action_dispatch/journey/router.rb:30:in `each'
actionpack (4.2.5.1) lib/action_dispatch/journey/router.rb:30:in `serve'
actionpack (4.2.5.1) lib/action_dispatch/routing/route_set.rb:815:in `call'
warden (1.2.5) lib/warden/manager.rb:35:in `block in call'
warden (1.2.5) lib/warden/manager.rb:34:in `catch'
warden (1.2.5) lib/warden/manager.rb:34:in `call'
rack (1.6.4) lib/rack/etag.rb:24:in `call'
rack (1.6.4) lib/rack/conditionalget.rb:25:in `call'
rack (1.6.4) lib/rack/head.rb:13:in `call'
actionpack (4.2.5.1) lib/action_dispatch/middleware/params_parser.rb:27:in `call'
actionpack (4.2.5.1) lib/action_dispatch/middleware/flash.rb:260:in `call'
rack (1.6.4) lib/rack/session/abstract/id.rb:225:in `context'
rack (1.6.4) lib/rack/session/abstract/id.rb:220:in `call'
actionpack (4.2.5.1) lib/action_dispatch/middleware/cookies.rb:560:in `call'
activerecord (4.2.5.1) lib/active_record/query_cache.rb:36:in `call'
activerecord (4.2.5.1) lib/active_record/connection_adapters/abstract/connection_pool.rb:653:in `call'
activerecord (4.2.5.1) lib/active_record/migration.rb:377:in `call'
actionpack (4.2.5.1) lib/action_dispatch/middleware/callbacks.rb:29:in `block in call'
activesupport (4.2.5.1) lib/active_support/callbacks.rb:88:in `__run_callbacks__'
activesupport (4.2.5.1) lib/active_support/callbacks.rb:778:in `_run_call_callbacks'
activesupport (4.2.5.1) lib/active_support/callbacks.rb:81:in `run_callbacks'
actionpack (4.2.5.1) lib/action_dispatch/middleware/callbacks.rb:27:in `call'
actionpack (4.2.5.1) lib/action_dispatch/middleware/reloader.rb:73:in `call'
actionpack (4.2.5.1) lib/action_dispatch/middleware/remote_ip.rb:78:in `call'
actionpack (4.2.5.1) lib/action_dispatch/middleware/debug_exceptions.rb:17:in `call'
web-console (2.3.0) lib/web_console/middleware.rb:28:in `block in call'
web-console (2.3.0) lib/web_console/middleware.rb:18:in `catch'
web-console (2.3.0) lib/web_console/middleware.rb:18:in `call'
actionpack (4.2.5.1) lib/action_dispatch/middleware/show_exceptions.rb:30:in `call'
railties (4.2.5.1) lib/rails/rack/logger.rb:38:in `call_app'
railties (4.2.5.1) lib/rails/rack/logger.rb:20:in `block in call'
activesupport (4.2.5.1) lib/active_support/tagged_logging.rb:68:in `block in tagged'
activesupport (4.2.5.1) lib/active_support/tagged_logging.rb:26:in `tagged'
activesupport (4.2.5.1) lib/active_support/tagged_logging.rb:68:in `tagged'
railties (4.2.5.1) lib/rails/rack/logger.rb:20:in `call'
request_store (1.3.0) lib/request_store/middleware.rb:9:in `call'
actionpack (4.2.5.1) lib/action_dispatch/middleware/request_id.rb:21:in `call'
rack (1.6.4) lib/rack/methodoverride.rb:22:in `call'
rack (1.6.4) lib/rack/runtime.rb:18:in `call'
activesupport (4.2.5.1) lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call'
rack (1.6.4) lib/rack/lock.rb:17:in `call'
actionpack (4.2.5.1) lib/action_dispatch/middleware/static.rb:116:in `call'
rack (1.6.4) lib/rack/sendfile.rb:113:in `call'
railties (4.2.5.1) lib/rails/engine.rb:518:in `call'
railties (4.2.5.1) lib/rails/application.rb:165:in `call'
rack (1.6.4) lib/rack/lock.rb:17:in `call'
rack (1.6.4) lib/rack/content_length.rb:15:in `call'
rack (1.6.4) lib/rack/handler/webrick.rb:88:in `service'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/2.3.0/webrick/httpserver.rb:140:in `service'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/2.3.0/webrick/httpserver.rb:96:in `run'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/2.3.0/webrick/server.rb:296:in `block in start_thread'
@nabeta
Copy link
Member Author

nabeta commented Jan 30, 2016

モバイル端末のテンプレート振り分けを行うmobyletteというgemでエラーが出ていますが、2年以上更新がなく、対応されるかどうか怪しいです。
https://github.com/tscolari/mobylette

enju_leaf-1.2ではbrowserという別のgemを使用しており、rails-4.2.5.1でも動作します。
https://github.com/fnando/browser

考えられる手段は以下のとおりですが、現実的には1か4ではないかと思います。いかがでしょうか。

  1. enju_leaf-1.1での実装をbrowserに置き換える。設定ファイル(app/controllers/application_controller.rb)の修正が必要
  2. mobyletteのパッチを作成する。設定ファイルの修正は不要だが作業の手間が大きい
  3. rails-4.2.5.1以降を使用しないようにenju_leafの依存関係を修正する。作業の手間は少ないが、railsのセキュリティ更新を受けられなくなる
  4. enju_leaf-1.1では対応せず、1.2にアップデートしてもらう

@nabeta nabeta added the bug label Jan 30, 2016
@masao
Copy link
Member

masao commented Jan 31, 2016

2または3でよいと思います。

@yegusa
Copy link

yegusa commented Jan 31, 2016

私も2または3でよいと思います。

@masao
Copy link
Member

masao commented Jan 31, 2016

FYI: https://github.com/eLocal/mobylette すでに4.2.5.1用のパッチ対応のフォークもあるようです(コミットログをみただけで、試してませんが)。

@nabeta
Copy link
Member Author

nabeta commented Jan 31, 2016

2はともかく、3はインターネットに公開するサービスとしてはありえないと思うのですが…。
ひとまずGemfileにフォークを追加する方法で対応したいと思います。

  1. Gemfileに以下の行を追加

    gem 'mobylette', github: 'eLocal/mobylette'
  2. bundle updateを実行

@scivola
Copy link
Contributor

scivola commented Jan 31, 2016

3 は絶対ダメです。
rails 4.2.5.1 は「可及的速やかなるアップグレードを推奨」となっています。
http://weblog.rubyonrails.org/2016/1/25/Rails-5-0-0-beta1-1-4-2-5-1-4-1-14-1-3-2-22-1-and-rails-html-sanitizer-1-0-3-have-been-released/

@yegusa yegusa added this to the 1.1.3 milestone Jan 31, 2016
@nabeta
Copy link
Member Author

nabeta commented Feb 11, 2016

1.1系のインストールスクリプトを、4.2.5.1対応版を使用するように修正しました。
https://gist.github.com/nabeta/5357321#file-enju_leaf_template-rb-L20

@nabeta
Copy link
Member Author

nabeta commented May 22, 2016

gem 'mobylette', github: 'eLocal/mobylette'

このフォークをテストで使用するように変更したのですが、Rails 4.1と4.2でテストが通りません。

Appraisals:

appraise "rails-4.1" do
  gem "rails", "~> 4.1.15"
  gem "jquery-rails"
  gem "foreigner"
  gem "coveralls", require: false
  gem 'mobylette', github: 'eLocal/mobylette'
end

エラー:

>> BUNDLE_GEMFILE=/Users/kosuke/enju_leaf/gemfiles/rails_4.1.gemfile bundle exec rake
rake aborted!
Bundler::GemRequireError: There was an error while trying to load the gem 'mobylette'.
Gem Load Error is: uninitialized constant ActionView::FileSystemResolver
Backtrace for gem load error is:
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/mobylette-d6c8b8db7a97/lib/mobylette/resolvers/chained_fallback_resolver.rb:3:in `<module:Resolvers>'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/mobylette-d6c8b8db7a97/lib/mobylette/resolvers/chained_fallback_resolver.rb:2:in `<module:Mobylette>'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/mobylette-d6c8b8db7a97/lib/mobylette/resolvers/chained_fallback_resolver.rb:1:in `<top (required)>'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/mobylette-d6c8b8db7a97/lib/mobylette.rb:5:in `require'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/mobylette-d6c8b8db7a97/lib/mobylette.rb:5:in `<module:Mobylette>'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/mobylette-d6c8b8db7a97/lib/mobylette.rb:3:in `<top (required)>'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/runtime.rb:86:in `require'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/runtime.rb:86:in `block (2 levels) in require'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/runtime.rb:81:in `each'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/runtime.rb:81:in `block in require'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/runtime.rb:70:in `each'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/runtime.rb:70:in `require'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler.rb:102:in `require'
/Users/kosuke/enju_leaf/spec/dummy/config/application.rb:5:in `<top (required)>'
/Users/kosuke/enju_leaf/spec/dummy/Rakefile:5:in `require'
/Users/kosuke/enju_leaf/spec/dummy/Rakefile:5:in `<top (required)>'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/railties-4.1.15/lib/rails/tasks/engine.rake:3:in `load'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/railties-4.1.15/lib/rails/tasks/engine.rake:3:in `block (2 levels) in <top (required)>'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task_manager.rb:218:in `in_namespace'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/dsl_definition.rb:140:in `namespace'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/railties-4.1.15/lib/rails/tasks/engine.rake:2:in `block in <top (required)>'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:248:in `block in execute'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:243:in `each'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:243:in `execute'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:187:in `block in invoke_with_call_chain'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/2.3.0/monitor.rb:214:in `mon_synchronize'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:180:in `invoke_with_call_chain'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:173:in `invoke'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:150:in `invoke_task'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/railties-4.1.15/lib/rails/tasks/engine.rake:72:in `<top (required)>'
/Users/kosuke/enju_leaf/Rakefile:24:in `load'
/Users/kosuke/enju_leaf/Rakefile:24:in `<top (required)>'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/rake_module.rb:28:in `load'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/rake_module.rb:28:in `load_rakefile'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:689:in `raw_load_rakefile'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:94:in `block in load_rakefile'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:176:in `standard_exception_handling'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:93:in `load_rakefile'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:77:in `block in run'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:176:in `standard_exception_handling'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:75:in `run'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/bin/rake:33:in `<top (required)>'
/Users/kosuke/.rbenv/versions/2.3.0/bin/rake:23:in `load'
/Users/kosuke/.rbenv/versions/2.3.0/bin/rake:23:in `<top (required)>'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/cli/exec.rb:63:in `load'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/cli/exec.rb:63:in `kernel_load'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/cli/exec.rb:24:in `run'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/cli.rb:304:in `exec'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/vendor/thor/lib/thor.rb:359:in `dispatch'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/vendor/thor/lib/thor/base.rb:440:in `start'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/cli.rb:11:in `start'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/exe/bundle:27:in `block in <top (required)>'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/lib/bundler/friendly_errors.rb:98:in `with_friendly_errors'
/Users/kosuke/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/bundler-1.12.4/exe/bundle:19:in `<top (required)>'
/Users/kosuke/.rbenv/versions/2.3.0/bin/bundle:23:in `load'
/Users/kosuke/.rbenv/versions/2.3.0/bin/bundle:23:in `<main>'
Bundler Error Backtrace:
/Users/kosuke/enju_leaf/spec/dummy/config/application.rb:5:in `<top (required)>'
/Users/kosuke/enju_leaf/spec/dummy/Rakefile:5:in `require'
/Users/kosuke/enju_leaf/spec/dummy/Rakefile:5:in `<top (required)>'
/Users/kosuke/enju_leaf/Rakefile:24:in `load'
/Users/kosuke/enju_leaf/Rakefile:24:in `<top (required)>'
/Users/kosuke/.rbenv/versions/2.3.0/bin/bundle:23:in `load'
/Users/kosuke/.rbenv/versions/2.3.0/bin/bundle:23:in `<main>'
NameError: uninitialized constant ActionView::FileSystemResolver
/Users/kosuke/enju_leaf/spec/dummy/config/application.rb:5:in `<top (required)>'
/Users/kosuke/enju_leaf/spec/dummy/Rakefile:5:in `require'
/Users/kosuke/enju_leaf/spec/dummy/Rakefile:5:in `<top (required)>'
/Users/kosuke/enju_leaf/Rakefile:24:in `load'
/Users/kosuke/enju_leaf/Rakefile:24:in `<top (required)>'
/Users/kosuke/.rbenv/versions/2.3.0/bin/bundle:23:in `load'
/Users/kosuke/.rbenv/versions/2.3.0/bin/bundle:23:in `<main>'
Tasks: TOP => load_app
(See full trace by running task with --trace)

対応すると思われるpull requestはマージされていません。
tscolari/mobylette#50

nabeta added a commit that referenced this issue May 22, 2016
@nabeta
Copy link
Member Author

nabeta commented Jun 27, 2016

mobyletteのモジュールを上書きしてテストを通すようにしました。
9cb06f2

@nabeta
Copy link
Member Author

nabeta commented Jul 30, 2016

1.1.3でテストを通しています。なお、現時点では以下の警告メッセージが出ます。

/home/kosuke/enju_leaf_11/vendor/bundle/ruby/2.2.0/gems/enju_leaf-1.1.3/lib/plugins/ext/mobylette/resolvers/chained_fallback_resolver.rb:4: warning: already initialized constant Mobylette::Resolvers::ChainedFallbackResolver::DEFAULT_PATTERN
/home/kosuke/enju_leaf_11/vendor/bundle/ruby/2.2.0/bundler/gems/mobylette-0d59cd76f5eb/lib/mobylette/resolvers/chained_fallback_resolver.rb:5: warning: previous definition of DEFAULT_PATTERN was here

@masao masao added the checking label Jul 30, 2016
@masao
Copy link
Member

masao commented Jul 30, 2016

リリースもおわって、現時点では問題は起きていないようなので、ひとまずクローズしましょうか。

@yegusa
Copy link

yegusa commented Jul 30, 2016

クローズ賛成です。

@nabeta
Copy link
Member Author

nabeta commented Aug 1, 2016

closeします。

@nabeta nabeta closed this as completed Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants