Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸš€ 4단계 - 사닀리(λ¦¬νŒ©ν„°λ§) #2159

Open
wants to merge 2 commits into
base: jioome
Choose a base branch
from
Open

πŸš€ 4단계 - 사닀리(λ¦¬νŒ©ν„°λ§) #2159

wants to merge 2 commits into from

Conversation

jioome
Copy link

@jioome jioome commented Apr 18, 2024

μ•ˆλ…•ν•˜μ„Έμš”. λ¦¬λ·°μ–΄λ‹˜! μ–΄λŠλ§ λ§ˆμ§€λ§‰ λ‹¨κ³„λ„€μš”πŸ˜­ λ§ˆμ§€λ§‰λ„ 잘 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€~
그리고 λ―Έμ…˜ μ§„ν–‰ν•˜λ©΄μ„œ μ–΄λ–€ λ‹¨μœ„λ‚˜ κΈ°μ€€μœΌλ‘œ 컀밋을 ν•˜λ©΄ 쒋을지 μ• λ§€ν•΄μ„œ κ³ λ―Όλ˜μ—ˆλ˜ 적이 λ§Žμ•˜λŠ”λ° κ·Έ λΆ€λΆ„ μ§ˆλ¬Έλ“œλ¦½λ‹ˆλ‹€!

kyucumber
kyucumber requested changes Apr 19, 2024
View reviewed changes
Copy link

@kyucumber kyucumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

크게 많이 바뀐 뢀뢄은 μ—†μ–΄μ„œ κ°„λ‹¨ν•œ μ½”λ©˜νŠΈ λ‚¨κ²¨λ‘μ—ˆμŠ΅λ‹ˆλ‹€.

확인 λΆ€νƒλ“œλ¦΄κ²Œμš”. λ‹€μ‹œ μš”μ²­μ£Όμ‹œλ©΄ λ¨Έμ§€ν•˜κ² μŠ΅λ‹ˆλ‹€.

src/main/java/nextstep/ladder/LadderMain.java
@@ -13,15 +13,14 @@ public class LadderMain {
public static void main(String[] args){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그리고 λ―Έμ…˜ μ§„ν–‰ν•˜λ©΄μ„œ μ–΄λ–€ λ‹¨μœ„λ‚˜ κΈ°μ€€μœΌλ‘œ 컀밋을 ν•˜λ©΄ 쒋을지 μ• λ§€ν•΄μ„œ κ³ λ―Όλ˜μ—ˆλ˜ 적이 λ§Žμ•˜λŠ”λ° κ·Έ λΆ€λΆ„ μ§ˆλ¬Έλ“œλ¦½λ‹ˆλ‹€!

λ‹€λ“€ λ‹€μ–‘ν•œ 방법을 μ‚¬μš©ν• κ±°λΌ 정닡은 μ—†μŠ΅λ‹ˆλ‹€. 참고만 λΆ€νƒλ“œλ €μš”

μ €λŠ” 일반적으둜 μ•„λž˜μ™€ 같은 방법을 많이 μ‚¬μš©ν•©λ‹ˆλ‹€.

  1. μ •ν™•ν•œ ν•œ λ‘κ°œμ˜ 클래슀λ₯Ό μž‘μ„±ν•˜λŠ” 경우 ν•΄λ‹Ή 클래슀 및 λ‹¨μœ„ ν…ŒμŠ€νŠΈ μž‘μ„±κΉŒμ§€ 컀밋
  2. λ‹€μ†Œ λ§Žμ€ μ½”λ“œλ₯Ό μž‘μ„±ν•΄μ•Ό ν•˜λŠ” 경우 μ—¬λŸ¬ 클래슀 및 이에 λŒ€ν•œ λ‹¨μœ„ ν…ŒμŠ€νŠΈλ₯Ό μž‘μ„±ν•˜κ³  λ™μž‘ν•˜κ²Œ λ§Œλ“  λ’€ 컀밋

2번의 경우 원격 μ €μž₯μ†Œμ— μž„μ‹œλ‘œ μ˜¬λ €μ•Όν•˜κ±°λ‚˜, μ €μž₯이 ν•„μš”ν•œ κ²½μš°λ„ μžˆλŠ”λ° 이 경우 항상 λ™μž‘ν•˜λŠ” μ½”λ“œ 기반의 컀밋을 λ§Œλ“€κΈ° μ–΄λ €μ›Œμ„œ μž„μ‹œλ‘œ 컀밋을 ν–ˆλ‹€κ°€ reset 을 톡해 컀밋을 μ •λ¦¬ν•˜κ³  μ˜¬λ¦¬λŠ” κ²½μš°κ°€ λ§Žμ€ 것 κ°™μ•„μš”.

src/main/java/nextstep/ladder/domain/Ladder.java
@@ -7,9 +7,9 @@
public class Ladder {
private final List<Line> lines;

public Ladder(final int numberOfPeople, final Height height) {
public Ladder(final int numberOfPeople, final int height) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν˜Ήμ‹œ λž˜ν•‘ 클래슀λ₯Ό μ œκ±°ν•˜μ‹  μ΄μœ κ°€ μžˆλ‚˜μš”? 0인 κ²½μš°μ— λŒ€ν•΄μ„œλŠ” μ˜ˆμ™Έκ°€ λ‚˜μ§€ μ•Šμ„ 것 같은데 μ˜λ„ν•˜μ‹  λΆ€λΆ„μΌκΉŒμš”?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyucumber kyucumber kyucumber requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jioome @kyucumber