Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2단계 - 문자열 계산기 #5657

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

2단계 - 문자열 계산기 #5657

wants to merge 27 commits into from
+234 −0

Commits on Sep 24, 2024

  1. 1단계 - 학습테스트 실습 (next-step#5569)

    @kdfasdf
    kdfasdf authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    afb3952 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. feat: implement requirement 1 

    - when empty string or null is given return 0
    @kdfasdf
    kdfasdf committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7f59c4d View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. feat: implement requirement 2 

    - when a number is given as String return it as int
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a7c96bb View commit details
    Browse the repository at this point in the history

  2. feat: implement requirement 3

    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e808659 View commit details
    Browse the repository at this point in the history

  3. implement requirement 4 

    - use comma or colon as delieter
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    2724f87 View commit details
    Browse the repository at this point in the history

  4. feat: implement requirement 5 

    custom delimeter test
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7255cec View commit details
    Browse the repository at this point in the history

  5. chore : rename file 

    - StringAddCalculator to StringAddCalculatorTest (src/test/java)
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d751a21 View commit details
    Browse the repository at this point in the history

  6. feat : implement requirement 6 

    - when negative number is given, RuntimeException is thrown
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    81050ba View commit details
    Browse the repository at this point in the history

  7. chore : 미사용 파일 삭제 및 주석 추가 

    - give when then 주석 추가 (src/test/java/StringAddCalculatorTest)
- .gitkeep 파일 제거 (src/main/java)
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a6163b7 View commit details
    Browse the repository at this point in the history

  8. chore : 구현 내용 초기화

    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    823b6cb View commit details
    Browse the repository at this point in the history

  9. feat : 요구사항1 구현 

    - 빈 문자열 또는 null 이면 0을 반환
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    bedc9d1 View commit details
    Browse the repository at this point in the history

  10. feat : 요구사항2 구현 

    - 숫자 하나 입력할 경우 해당 숫자 반환
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    00b6c48 View commit details
    Browse the repository at this point in the history

  11. feat : 요구사항 3 구현 

    - 숫자 두개를 컴마 구분자로 입력할 경우 두 숫자의 합 반환
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4f9474d View commit details
    Browse the repository at this point in the history

  12. feat : 요구사항 4 구현 

    - 구분자를 컴마 이외에 콜론을 사용할 수 있다
- 사용되지 않는 import 구문 제거
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7da8790 View commit details
    Browse the repository at this point in the history

  13. feat : 요구사항 5 구현 

    - 커스텀 구분자 사용를 지정할 수 있다
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e557d7a View commit details
    Browse the repository at this point in the history

  14. feat : 요구사항 6 구현 

    - 음수를 전달할 경우 RuntimeException 예외가 발생해야 한다
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7415048 View commit details
    Browse the repository at this point in the history

  15. chore : 상수추출 및 불필요한 메서드(validnegative) 제거

    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3fad8a6 View commit details
    Browse the repository at this point in the history

  16. refactor : 숫자 합을 구하는 공통 로직, calculateSum 메서드로 추출

    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c8ea667 View commit details
    Browse the repository at this point in the history

  17. chore : 불필요한 지역변수 제거 

    - splitAndSumWithComma (src/main/java)
- splitAndSumWithCommaOrColon (src/main/java)
- splitWithCustomDelimeter (src/main/java)
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    15b2371 View commit details
    Browse the repository at this point in the history

  18. refactor : if문 validNegativeNumberString메서드로 분리 

    - negativeValidation (src/main/java/StringAddCalculator.class)
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    2249f09 View commit details
    Browse the repository at this point in the history

  19. refactor : 정수 형변환 toInt()메서드로 책임 분리 

    - calculateSum(src/main/java/StringAddCalculator.class)
    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    188ea61 View commit details
    Browse the repository at this point in the history

  20. chore : 코드 자동 정렬

    @kdfasdf
    kdfasdf committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8604a7e View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. refactor : 요구사항 1, 2 재구현 및 private() 생성자 

    - 아래 메서드들을 splitAndSum에 재구현
- emptyOrNull
- processOneNumberString
    @kdfasdf
    kdfasdf committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3f0e234 View commit details
    Browse the repository at this point in the history

  2. refactor : 요구사항 3 재구현 

    - splitAndSumWithComma를 splitAndSum에 구현
    @kdfasdf
    kdfasdf committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    639fcfc View commit details
    Browse the repository at this point in the history

  3. refactor : 요구사항 4 재구현

    @kdfasdf
    kdfasdf committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    4a4aa08 View commit details
    Browse the repository at this point in the history

  4. refactor : 피드백 반영 및 요구사항 5 재구현 

    - Pattern 객체 상수로 추출
- splitWithCustomDelimeter 기능을 splitAndSum에 통합
    @kdfasdf
    kdfasdf committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    13c2117 View commit details
    Browse the repository at this point in the history

  5. refactor : 요구사항 6 재구현 및 피드백 반영 

    - StringAddCalculator.java (src/main/java)
- negativeValidation()을 splitAndSum()에 기능 통합
- calculateSum()에 isNegative() 추가
    @kdfasdf
    kdfasdf committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    f9458c1 View commit details
    Browse the repository at this point in the history