Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Show Failed Upload Message For Same File and Handle Local Behavior #14410

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Don't Show Failed Upload Message For Same File and Handle Local Behavior #14410

wants to merge 5 commits into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jan 15, 2025 •
edited
Loading

  • Tests written, or not not needed

• Removes messages related to failed uploads
• Manages local behavior in cases of upload synchronization conflicts and when the remote directory contains the same file

@alperozturk96 alperozturk96 linked an issue Jan 15, 2025 that may be closed by this pull request
Same file already exists, no conflict detected toast infinitely #14402
Open
4 tasks
@alperozturk96 alperozturk96 mentioned this pull request Jan 15, 2025
Open
4 tasks
@alperozturk96 alperozturk96 removed the request for review from tobiasKaminsky January 15, 2025 13:52
@alperozturk96 alperozturk96 changed the title Don't Show Failed Upload Message For Same File Don't Show Failed Upload Message For Same File and Handle Failed Upload Jan 15, 2025
@alperozturk96 alperozturk96 changed the title Don't Show Failed Upload Message For Same File and Handle Failed Upload Don't Show Failed Upload Message For Same File and Handle Local Behavior Jan 15, 2025
@alperozturk96 alperozturk96 force-pushed the dont-show-failed-upload-message-for-same-file branch from 799df72 to ab190f5 Compare January 15, 2025 14:01
@alperozturk96
handleLocalBehaviour
b3981bd 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
check variables
d35eb72 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
add e2e variant
0dd4241 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
e2e not supported for auto upload
a2aaa8c 
Signed-off-by: alperozturk <[email protected]>
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14410.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5555
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total504504

@bilogic
Copy link

bilogic commented Jan 17, 2025

thanks for the PR, it solves the problem, but because it is another fresh installation, I cannot re-use my config from the GA version or the DEV version and had to reconfigure the entire app from scratch...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Same file already exists, no conflict detected toast infinitely
2 participants
@alperozturk96 @bilogic