#7815 Delayed synchronization

[BatPio]

Fixes #7815
Fixes #2323

• Tests written, or not not needed
  Some tests are written. I'm waiting for suggestions on what else can be tested.

Delay configuration:

[codecov]

Codecov Report

Merging #11278 (3d40c3a) into master (aeb1632) will increase coverage by 0.07%.
The diff coverage is 37.20%.

❗ Current head 3d40c3a differs from pull request most recent head 501d1fe. Consider uploading reports for the commit 501d1fe to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #11278      +/-   ##
============================================
+ Coverage     31.44%   31.52%   +0.07%     
- Complexity     3413     3427      +14     
============================================
  Files           575      577       +2     
  Lines         42018    42146     +128     
  Branches       5660     5664       +4     
============================================
+ Hits          13214    13286      +72     
- Misses        26861    26905      +44     
- Partials       1943     1955      +12     

Impacted Files	Coverage Δ
...com/nextcloud/client/database/NextcloudDatabase.kt	100.00% <ø> (ø)
...cloud/client/database/entity/SyncedFolderEntity.kt	0.00% <0.00%> (ø)
...java/com/nextcloud/client/di/ComponentsModule.java	0.00% <ø> (ø)
...in/java/com/nextcloud/client/jobs/FilesSyncWork.kt	21.95% <0.00%> (-0.18%)	⬇️
...loud/android/datamodel/FilesystemDataProvider.java	4.39% <0.00%> (-0.10%)	⬇️
...oud/android/datamodel/SyncedFolderDisplayItem.java	35.29% <ø> (ø)
...ncloud/android/datamodel/SyncedFolderProvider.java	10.93% <0.00%> (-0.18%)	⬇️
...ain/java/com/owncloud/android/db/ProviderMeta.java	100.00% <ø> (ø)
...cloud/android/ui/activity/SyncedFoldersActivity.kt	20.43% <0.00%> (-0.55%)	⬇️
.../dialog/SyncedFolderPreferencesDialogFragment.java	0.00% <0.00%> (ø)
... and 11 more

[AlvaroBrey]

I haven't tested this yet, especially to see how this will behave with existing autoupload folders. This can't be tested without adressing my first comment below, however.

Having said that, this looks quite promising! Thanks for contributing @BatPio

[BatPio]

@alperozturk96
Testing is time-consuming.

After setting the auto upload delay for a directory, you need to add a new file to that directory and wait. After the delay time has elapsed, the file should appear on the server. It is important to check that the file has not appeared on the server before the delay time has elapsed. Due to the Android's sync interval, the delay may increase by an additional 15 minutes.
In case of a 30-minute delay, the file should appear on server no earlier than after 30 minutes and no later than after 45 minutes.

I tested this with screenshots. Unfortunately, I have no idea how to test this without waiting.

[BatPio]

@alperozturk96

I have adapted my code to the current solution with FilesystemDataProvider. MR is ready for testing

[alperozturk96]

@tobiasKaminsky @ZetaTom

I tested auto upload seems like okay. Could you please review, especially FilesystemDataProvider.java and FilesSyncWork.kt ?

[ZetaTom]

Thank you for taking the time to contribute these enhancements and for maintaining this pull request.

In general this seems to work. The duration selector dialogue is very intuitive. Great work!

The phrase Delay file upload suggests that the upload of a given file is delayed. However, we're only looking for files older than the specified time. This becomes an issue when there are files already present or when files are moved to the auto upload folder. These files will most likely be uploaded immediately. To address this issue, I would suggest to rename the feature to something like Exclude recent files or Minimum file age.

I think that we should involve @Hyeyoung346 in this discussion.

[ZetaTom]

Suggested change

	<string name="common_minutes_short">m</string>
	<string name="common_minutes_short">min</string>

To my knowledge min is the standard abbreviation.

[ZetaTom]

I'm not sure that this value will work using different font sizes and faces. I've also noticed that the clear button (⊗) disappears on smaller screen sizes.