Cypress tests are failing with current master

[max-nextcloud]

Describe the bug
Cypress tests have been failing recently. In particular three tests in pages-links.spec.js:

• Opens link with absolute path to text file in Nextcloud in viewer
• Opens link with relative path to pdf in Nextcloud in viewer
• Opens link with absolute path to image in Nextcloud in viewer

To Reproduce
Steps to reproduce the behavior:

1. Visit a recent dependency PR such as fix(deps): update dependency @nextcloud/moment to ^1.3.1 #1071
2. Check the failed cypress tests on master.
3. Find the failure there

Expected behavior
Cypress tests should pass and dependency PRs should be merge automatically.

Screenshots

Server details:

• Current Cypress master CI

Client details:

• electron

Nextcloud log (data/nextcloud.log)

Nextcloud logs are empty (i.e. no errors) for the run in question.

[max-nextcloud]

I tried to reproduce this locally with latest master, viewer and collectives but failed.

update: fails now that i am using the latest version of text.

[max-nextcloud]

I tried to bisect which commit in text introduced this but failed. Now that I got the test to fail i cannot get it to pass again. It even failed when i had the same text commit checked out as during the last passing CI run.

Since I had a local failure now i could debug it some. Looks like it the first failing test tries to open //test.png:

But the list of files after fetching the metadata only contains a file called /test.png so when the viewer tries to calculate the current index that is -1 and later the file to open is empty leading to exceptions.

@mejo- does that sound familiar to you?

[mejo-]

This is fixed.