Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too slow with big number of cards #1780

Open
matchish opened this issue May 2, 2020 · 14 comments
Open

Too slow with big number of cards #1780

matchish opened this issue May 2, 2020 · 14 comments

Comments

@matchish
Copy link
Contributor

matchish commented May 2, 2020

Describe the bug
Every action take too much time if you have big number of cards

To Reproduce
I have 170 cards on my board.

Expected behavior
Rerender have to be completed in less then one second

Screenshots
screenshot

Client details:

  • OS: Doesn't matter
  • Browser: I've tried different

I've reproduced the issue in deck: 1.0.0-beta2

@juliusknorr
Copy link
Member

Please share some details about your setup, as the main delay in the profiling seem to be caused by slow server responses.

@matchish
Copy link
Contributor Author

matchish commented May 6, 2020

Server response speed is acceptable
image

@matchish
Copy link
Contributor Author

matchish commented May 6, 2020

Now I'm testing on my laptop
image

Nextcloud 19.0.0 beta 6
Deck 1.0.0-beta2

@matchish
Copy link
Contributor Author

matchish commented May 6, 2020

And here is just moving card from one stack to another
image
And here is network activity for moving card
image
So I believe it's frontend issue

@jakobroehrl
Copy link
Contributor

@juliushaertl done with #1903, too?

@matchish
Copy link
Contributor Author

I'll check on the next week

@juliusknorr
Copy link
Member

There is still some room left for optimization but this should already help a lot yes. Let me close this for now, but feel free to reopen, if you still encounter issues with the next release.

@matchish
Copy link
Contributor Author

Now moving cards much faster but still slow if you have a lot of cards. I have to reduce amount of cards to have acceptable performance. I've attached dump with my current masked deck to reproduce the case
deck_dump.zip

@matchish matchish reopened this Jul 10, 2020
@juliusknorr
Copy link
Member

Thanks alot for providing some test data 🚀

I'll have another look.

@renekliment
Copy link

Hi! I absolutely love Deck and use it probably every day. Unfortunately the web UI is very slow at various things, which is frustrating at times. This is a screenshot of a profile when I simply try to open a card and have to wait for a long time for it to come up. I have a lot of cards on the board, but I don't see a reason why opening a card should cause a "Recalculate Style" that takes seconds. 🙀
Do you have and clue as to what this is caused by?

Screenshot_2023-05-06_12-02-07

@renekliment
Copy link

renekliment commented May 18, 2023

So I have tried to look at this a bit.

The problem is when I try to open a card by clicking on it, vue-smooth-dnd causes those 2 first huge & useless style recalculations. I am not sure if it is a bug in the library or its usage. If I simply replace its components with divs, the the recalcs are gone.

I will try to look further, but I am new to Vue and Nextcloud apps development, so it may take quite some time and I may not get anywhere, hence no promises.

EDIT: It may be related to atlassian/react-beautiful-dnd#2316 which is a different library but I believe it does the same thing by applying those styles to the body. Needs further investigation.

@juliusknorr
Copy link
Member

Thanks for diving into this. I haven't checked further, but it might be related to the start/end handling of vue-smooth-dnd. I noticed that there is a :drag-begin-delay property which defaults to 0. Might be worth to experiment with that if not triggering drag and drop behaviour immediately improves the situation.

@sadeghmohebbi
Copy link

sadeghmohebbi commented Apr 3, 2024

any work on this issue? it's still alive.
I'm tested it. for boards more than 200 cards, board loading is too slow even API response time around 1s.

@aquananu
Copy link

i was also trying to pinpoint the issue of slow deck loading, i have been able to find that core-common.js is waiting to get completed and the content download is still going on even after 2.6 mins from request submission

ca anyone suggest why this could be there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants