-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust board background to new design of tasks app #2166
Conversation
Signed-off-by: Simon Spannagel <[email protected]>
@jancborchardt What do you think? I think it still could be a bit lighter than the default background-dark |
Hmm. I'm not sure. Looks a bit boring and old school. ;-) Maybe make the background a bit lighter. Maybe some more rounded corners of the cards. And in general maybe take some inspiration from the new dashboard? @juliushaertl @jancborchardt |
Several points or questions here:
|
For Tasks we introduced a grey background with nextcloud/tasks#1136. Having it equal in Deck would make sense, I think. The background image from Dashboard could also be nice, then you could choose whether an image or plain color or whatever is shown (ideally complemented by the ability to select a different background color than the primary one for the Dashboard). |
I personally prefer the white one as well, but we have this request from time to time where people suggest to add some more contrast between cards and the background.
The screenshot in here was a bit outdated, the border radius is already adjusted. Here is an updated one with the slight blue-ish background as you proposed. Would be fine by me this way:
I personally think that a background image adds a lot of distraction from the actual content, so I'd rather not have this by default at least. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonspa Mind to adjust that to the proposal above and rebase? :)
Moving the milestone, since we would need a server css variable first as discussed via chat. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Summary
This adjusts the background of boards to be slightly darker, following the recent design change in the Tasks app (nextcloud/tasks#1136). i think the individual cards stick out better from this background.
This would of course be quite a change that, I guess, should be discussed (also cc'ing @jancborchardt here...)
Also, with stronger visual distinction between board and app sidebar, it feels like the sidebar elements are too close to its edge.
Checklist