Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud Files displays wrong "Modified" date after reading/closing a Collabora file without making any modification #3109

Closed
RodSeq opened this issue Aug 14, 2023 · 8 comments
Labels
bug Something isn't working upstream: collabora online

Comments

@RodSeq
Copy link

RodSeq commented Aug 14, 2023

Describe the bug
When I read a file with latest version Nextcloud 27.0.1 + Nextcloud Office 8.1.1 + Collabora CODE 23.05.2, then close the file without making any modification to the file: Nexcloud Files always wrongly displays that the file has been modified "seconds ago". Refreshing the page, Nextcloud Files always displays the correct latest modification date & hour of the file.

To Reproduce
Steps to reproduce the behavior:

  1. Open a file with Nextcloud Office + Collabora CODE.
  2. Close the file without making any modification to the file.
  3. Check the "Modified" column: Nextcloud Files always wrongly displays that the file has been modified "seconds ago"

Expected behavior
When I read a file using Nextcloud Office + Collabora CODE then close the file without making any modification, Nextcloud Files should always display the latest modification date & hour in the "Modified" column

Server details

Database: 10.5.21
PHP version: 8.1.21
Nextcloud version: 27.0.1.2
Version of the richdocuments app: 8.1.0
Version of Collabora Online: 23.05.2

@RodSeq RodSeq changed the title Nextcloud Office displays a wrong "Modified" date when closing a file that hasn't been modified Nextcloud Office always displays a wrong "Modified" date when closing a file that hasn't been modified Aug 14, 2023
@RodSeq RodSeq changed the title Nextcloud Office always displays a wrong "Modified" date when closing a file that hasn't been modified Nextcloud always displays a wrong "Modified" date when closing a file that hasn't been modified Aug 14, 2023
@RodSeq RodSeq changed the title Nextcloud always displays a wrong "Modified" date when closing a file that hasn't been modified Nextcloud Office always displays a wrong "Modified" date when closing a Collabora file that hasn't been modified Aug 14, 2023
@RodSeq RodSeq changed the title Nextcloud Office always displays a wrong "Modified" date when closing a Collabora file that hasn't been modified Nextcloud Office always displays a wrong "Modified" date when closing a file that hasn't been modified Aug 14, 2023
@RodSeq RodSeq changed the title Nextcloud Office always displays a wrong "Modified" date when closing a file that hasn't been modified Nextcloud always displays a wrong "Modified" date when closing a file that hasn't been modified Aug 14, 2023
@RodSeq RodSeq changed the title Nextcloud always displays a wrong "Modified" date when closing a file that hasn't been modified Nextcloud Files displays wrong "Modified" date after reading/closing a file without making any modification Aug 17, 2023
@RodSeq RodSeq changed the title Nextcloud Files displays wrong "Modified" date after reading/closing a file without making any modification Nextcloud Files displays wrong "Modified" date after reading/closing a Collabora file without making any modification Aug 17, 2023
@rotdrop
Copy link

rotdrop commented Aug 21, 2023

I have the same problem. Actually, I think the point is here that the file actually is saved by the app although it has not been modified. So the bug is not that the underlying core services do something wrong, but that the file is actually written. I have verified this, and also that the generated versions are actually byte-by-byte identical.

This is a bit annoying as it also means that the versions file space is polluted with "ghost-versions" with no change which just consume space on the server.

@rotdrop rotdrop added the bug Something isn't working label Aug 21, 2023
@rotdrop
Copy link

rotdrop commented Aug 21, 2023

... I actually just read that my issue seems to be different as NC actually does save the unmodified file and generates new versions. @RodSeq: can you verify that in your case really no new versions of the file are generated and the file isn't actually saved? Because in my case the file is actually written to disk and in my server logs I see

... "POST /index.php/apps/richdocuments/wopi/files/18588_ocbnl45ljkp9/contents?access_token=... "COOLWSD HTTP Agent 23.05.2.2" 

which means that the "code"-server is actually requesting a putFile() when closing the unmodified document.

@chris-meyer3
Copy link

chris-meyer3 commented Jan 21, 2024

Same problem here in NC 28.0.1 (and earlier 27.x).

[...] "POST //index.php/apps/richdocuments/wopi/files/23834_ocqyqx2tl9sg/contents?access_token=[...]&access_token_ttl=0%2Fws%3FWOPISrc%3Dhttps%3A%2F%2F[...]%2F%2Findex.php%2Fapps%2Frichdocuments%2Fwopi%2Ffiles%2F23834_ocqyqx2tl9sg&compat= HTTP/1.1" 200 1675 "-" "COOLWSD HTTP Agent 23.05.7.2"

@chris-meyer3
Copy link

Any progress on this issue?
TNX

@joshtrichards
Copy link
Member

Related: #2771

#2771 (comment)

@chris-meyer3
Copy link

chris-meyer3 commented Nov 23, 2024

There is some progress.

The situation is different today. Most recently, all office applications were affected by the incorrect date. Today, only the file formats of the 'calc' application seems to be affected.

Wrong file date:
*.ods
*.xsl, *.xlsx

Correct file date:
*.odt
*.odp
*.doc, *.docx
*.ppt, *.pptx

[Nextcloud Hub 8] (29.0.8)
Collabora Online - Built-in CODE Server - Version 24.4.902

@chris-meyer3
Copy link

Same behavior in NC 30.0.3 + Collabora 24.4.1002

@juliusknorr
Copy link
Member

@chris-meyer3 That is an interesting finding. I think we move this report over to https://github.com/CollaboraOnline/online as the place where the change of the file is triggered.

Could you file an issue over there?

FYI @pedropintosilva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream: collabora online
Projects
None yet
Development

No branches or pull requests

5 participants