Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix edit link #33

Merged
merged 2 commits into from
May 7, 2024
Merged

Docs: Fix edit link #33

merged 2 commits into from
May 7, 2024

Conversation

ewels
Copy link
Member

@ewels ewels commented May 7, 2024

master, not main

@ewels
Copy link
Member Author

ewels commented May 7, 2024

@nvnieuwk I find the page title Create a list a bit unintuitive. I know you changed it because it's not a channel factory any more, but the page is still all about creating channels.

What do you think about reverting the name change?

@nvnieuwk
Copy link
Collaborator

nvnieuwk commented May 7, 2024

That's fine by me :). I didn't really think of it that much while rewriting that part of the docs

@ewels ewels merged commit c0cace6 into master May 7, 2024
6 checks passed
@ewels ewels deleted the fix-docs-edit branch May 7, 2024 14:37
@ewels ewels mentioned this pull request May 7, 2024
Merged
@ewels
Copy link
Member Author

ewels commented May 7, 2024

PR #34 submitted to make that change 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewels @nvnieuwk