ENG-4443 Part 1. Create update scripts to update an app and the manifest #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-quintero
requested review from
cowanwalls,
merschformann and
nilsbeck
cowanwalls
approved these changes
Feb 1, 2024
nilsbeck
reviewed
Feb 2, 2024
merschformann
approved these changes
Feb 2, 2024
sebastian-quintero
requested review from
nilsbeck,
merschformann and
cowanwalls
|
@merschformann @cowanwalls @nilsbeck I changed the scripts significantly from the comments so I want to have a re-review. I basically consolidated what I had into a single Python script. I think it looks nice and it is very maintainable going forward. What I would be missing is tarring, which comes next. |
cowanwalls
approved these changes
Feb 2, 2024
sebastian-quintero
deleted the
feature/eng-4443-create-release-workflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates two main scripts.
update_manifest.py: updates the manifest to include the new versions on release.update_app.sh: updates an app. If it is a Go app, updates the SDK dependency as well.Sets the initial versions on all apps to be the latest released version on the Marketplace.