Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coloring display when tree is missing attribute #737

Closed
trvrb opened this issue Jul 11, 2019 · 2 comments
Closed

Coloring display when tree is missing attribute #737

trvrb opened this issue Jul 11, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@trvrb
Copy link
Member

trvrb commented Jul 11, 2019

This bug was discovered for seasonal flu here: nextstrain/seasonal-flu#33 and can be seen live at https://nextstrain.org/flu/seasonal/h1n1pdm/na/2y?c=ep. Basically, the auspice config specifics ep as a coloring attribute, but ep does exist as an attribute anywhere in the tree. This could be viewed as augur user error (and we should fix this in seasonal flu), however, it would be nice if auspice handled this a bit more gracefully.

I would say this is low priority, but I suspect not too difficult to deal with.

@jameshadfield jameshadfield added the bug Something isn't working label Jul 12, 2019
@jameshadfield
Copy link
Member

Good find. Did augur validate pick this up? I hope that after augur v6 all the builds will start validating the JSONs, but I agree that auspice should handle this better 👍

@trvrb
Copy link
Member Author

trvrb commented Jan 22, 2021

Looks like this resolved itself. I'm closing the issue now.

@trvrb trvrb closed this as completed Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants