Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextclade Web: Confusing unwanted dataset switching #1462

Open
ivan-aksamentov opened this issue May 30, 2024 · 3 comments
Open

Nextclade Web: Confusing unwanted dataset switching #1462

ivan-aksamentov opened this issue May 30, 2024 · 3 comments
Labels
t:bug Type: bug, error, something isn't working

Comments

@ivan-aksamentov
Copy link
Member

ivan-aksamentov commented May 30, 2024

Reported by @tsibley here

For me, the "Suggest automatically" feature of Nextclade was enabled by default (though it seems like a sticky preference?). With it enabled:

  1. Load a Nextstrain dataset via the URL, e.g. https://nextclade-git-feat-fetch-auspice-sidecar-json-nextstrain.vercel.app/?dataset-json-url=https://nextstrain.org/ncov/gisaid/global/all-time
  2. Load a file of sequences
  3. Notice suggestions are made for an official dataset, but the one manually loaded via the URL remains selected.
  4. Run the analysis.
  5. Flip back to "Start".
  6. Notice that the dataset has been switched out for one of the suggested ones.

This seems confusing?

@ivan-aksamentov ivan-aksamentov added t:bug Type: bug, error, something isn't working good first issue Good for newcomers help wanted Extra attention is needed needs triage Mark for review and label assignment and removed good first issue Good for newcomers help wanted Extra attention is needed needs triage Mark for review and label assignment labels May 30, 2024
@ivan-aksamentov
Copy link
Member Author

@tsibley I could not immediately reproduce this. For me the tree-based external dataset is displayed in step 6. I am using Chromium browser.

Could there be some additional conditions or steps to reproduce this? Could you make a screen-cast when you have a spare minute?

01.m.mp4

@ivan-aksamentov
Copy link
Member Author

There is a serious problem with local storage since #1455. It might be causing various flukes, including this one. I added another issue: #1464.

@tsibley
Copy link
Member

tsibley commented May 30, 2024

Ah! I just tested this again and to reproduce I have to flip from Results → Dataset → Start. It's fine if I flip directly from Results → Start; the custom dataset stays selected. It's also fine if auto-suggest is disabled, even going from Results → Dataset → Start.

I suspect the screencast is unnecessary with the above info, but since I made it anyway here it is.

Screencast_00001.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:bug Type: bug, error, something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants