Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max marker setting even counts markers that are off #1476

Open
corneliusroemer opened this issue Jun 5, 2024 · 0 comments
Open

Max marker setting even counts markers that are off #1476

corneliusroemer opened this issue Jun 5, 2024 · 0 comments
Labels
package: nextclade_web t:bug Type: bug, error, something isn't working

Comments

@corneliusroemer
Copy link
Member

To keep the UI smooth, we disable marker preview when there are too many markers.

When trying to view a sequence with many N ranges but few mutations, I expected to be able to just switch off the display of N ranges and then be able to get below the marker limit.

Unfortunately that didn't work!

With those settings:
Brave Browser 2024-06-05 13 55 38

I still get hidden markers:

image

There are two ways forward:

  • quick: rename the "Max nucleotide markers" to "Maximum markers (including hidden)" (the mention of nucleotide is wrong here, as all sorts of markers are counted not just nucleotides)
  • Improve visibility business logic to only count enabled markers towards the threshold
@corneliusroemer corneliusroemer added t:bug Type: bug, error, something isn't working good first issue Good for newcomers help wanted Extra attention is needed needs triage Mark for review and label assignment package: nextclade_web and removed good first issue Good for newcomers help wanted Extra attention is needed labels Jun 5, 2024
@ivan-aksamentov ivan-aksamentov removed the needs triage Mark for review and label assignment label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: nextclade_web t:bug Type: bug, error, something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants