Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/Visual: Display positions of single N markers differ slightly from non-Ns in nuc seq view #708

Closed
danrlu opened this issue Jan 27, 2022 · 5 comments
Labels
package: nextclade_web t:bug Type: bug, error, something isn't working

Comments

@danrlu
Copy link

danrlu commented Jan 27, 2022

Nextclade is SO useful. Thank you for building it and always improving it!!

We noticed a minor issue. We have 2 sequences, 1 has lots of Ns where they are mutations in the other sequence. The bars don't quite line up:

image

Take the blue bar for example:
The position of N:
image

The position of blue bar:
image

The yellow bar:
image

image

@danrlu danrlu added good first issue Good for newcomers help wanted Extra attention is needed needs triage Mark for review and label assignment t:bug Type: bug, error, something isn't working labels Jan 27, 2022
@corneliusroemer corneliusroemer added package: nextclade_web and removed good first issue Good for newcomers help wanted Extra attention is needed needs triage Mark for review and label assignment labels Jan 27, 2022
@corneliusroemer
Copy link
Member

corneliusroemer commented Jan 27, 2022

Thank you very much for reporting this issue. I agree that single Ns should align with single substitution markers.

The root problem is that to make markers visible, they are magnified. We've tried to improve alignment in the past, centering ranges of mutations - but we may have forgotten about Ns, or single Ns.

May be related to this PR: #644 for this issue #631

@corneliusroemer corneliusroemer changed the title Position of N varies slightly with non-Ns in the graph BUG/Visual: Display positions of single N markers differ slightly from non-Ns in nuc seq view Jan 27, 2022
@corneliusroemer
Copy link
Member

corneliusroemer commented Jan 27, 2022

I can reproduce it, and also noticed that we seem to cut off mutations at the very right hand side of the ref sequence, so we may want to pad the view a bit more.
image
n_vs_mut_fasta.txt

@rneher
Copy link
Member

rneher commented Jan 27, 2022

this is likely due to one of markers being centered and the other left-aligned. We changed mutations to be centered a while back, but might not have handled the missing marker the same way.

@ivan-aksamentov
Copy link
Member

I attempted to address this and a similar issue with other sequence markers in the PR #709

@danrlu Could you please check if it looks any better with the fix, by using this preview app:
https://nextclade-git-fix-center-markers-nextstrain.vercel.app/
?

@danrlu
Copy link
Author

danrlu commented Jan 27, 2022

Beautiful! Thank you all!!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: nextclade_web t:bug Type: bug, error, something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants