-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG/Visual: Display positions of single N markers differ slightly from non-Ns in nuc seq view #708
Comments
Thank you very much for reporting this issue. I agree that single Ns should align with single substitution markers. The root problem is that to make markers visible, they are magnified. We've tried to improve alignment in the past, centering ranges of mutations - but we may have forgotten about Ns, or single Ns. |
I can reproduce it, and also noticed that we seem to cut off mutations at the very right hand side of the ref sequence, so we may want to pad the view a bit more. |
this is likely due to one of markers being centered and the other left-aligned. We changed mutations to be centered a while back, but might not have handled the missing marker the same way. |
I attempted to address this and a similar issue with other sequence markers in the PR #709 @danrlu Could you please check if it looks any better with the fix, by using this preview app: |
Nextclade is SO useful. Thank you for building it and always improving it!!
We noticed a minor issue. We have 2 sequences, 1 has lots of Ns where they are mutations in the other sequence. The bars don't quite line up:
Take the blue bar for example:
![image](https://user-images.githubusercontent.com/20667188/151392415-aa9dc5c0-c236-46f7-87d4-d79a75cdafdf.png)
The position of N:
The position of blue bar:
![image](https://user-images.githubusercontent.com/20667188/151392492-376d7526-2bfd-49b9-ae47-6a1839ee6ab3.png)
The yellow bar:
![image](https://user-images.githubusercontent.com/20667188/151392597-04b0117f-013d-4367-a8a0-1c9a790f7539.png)
The text was updated successfully, but these errors were encountered: