Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename master to main #4

Closed
Tracked by #8
genehack opened this issue May 23, 2024 · 8 comments
Closed
Tracked by #8

Rename master to main #4

genehack opened this issue May 23, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request proposal Proposals that warrant further discussion

Comments

@genehack
Copy link
Contributor

pathogen-repo-guide and various other "modern" repos use main.

Using main also aligns with currently recognized best practices in the broader open source community.

From talking to folks, I understand this has caused some degree of disruption due to various places assuming master; I've also been cautioned to use @ as a branch label to ameliorate this.

Opening this as a place for discussion on what direction to go with yellow-fever.

@genehack genehack added enhancement New feature or request proposal Proposals that warrant further discussion labels May 23, 2024
@genehack genehack self-assigned this May 23, 2024
@joverlee521
Copy link

+1 for switch to main, especially before more people touch yellow-fever

@victorlin
Copy link
Member

Lots of discussion in an old Slack thread. I'm +1 for switching across all repos given shared agreement on a process to minimize/address disruptions.

@j23414
Copy link
Contributor

j23414 commented May 23, 2024

+1 for switch to main

@genehack
Copy link
Contributor Author

Lots of discussion in an old Slack thread.

Thanks for that pointer.

I'm +1 for switching across all repos given shared agreement on a process to minimize/address disruptions.

Given the above discussion, I am not proposing or volunteering to undertake "across all repos" at this time 😁 I am gonna proceed with yellow-fever once I get the initial cleanup stuff merged, and I will default to main for any new repos I create.

I'm also willing to track this overall and try to roll it out across more repos as time goes on.

@genehack
Copy link
Contributor Author

genehack commented Jun 3, 2024

So, wrinkle: probably the best way to do this is renaming with the GitHub UI (because then there will be a redirect for any old URLs that point to master over to main) ...but that requires admin access to the repo, which I don't have.

Option nextstrain/private#1: somebody who has admin, do the work (I can still handle making the tickets and cleaning up any other master usage in workflows, etc)
Option nextstrain/private#2: give me repo admin on ...many repos, and then I do all the work

No strong preference, just trying to keep this work moving forward…

@j23414
Copy link
Contributor

j23414 commented Jun 3, 2024

I vote #2 but no strong preference, I think only @jameshadfield has admin for yellow-fever.

@huddlej
Copy link

huddlej commented Jun 3, 2024

@genehack Reposting from Slack, but I just updated your role in the Nextstrain organization to "Owner", so you should be able to choose Option 2 now.

@genehack
Copy link
Contributor Author

genehack commented Jun 4, 2024

Renamed.

Note that any existing checkouts will need to run the following commands in the working copy:

git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a

@genehack genehack closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proposal Proposals that warrant further discussion
Projects
None yet
Development

No branches or pull requests

5 participants