Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the enchanting "spells" as well as formulas? #18

Open
kristianronningen opened this issue Jun 7, 2021 · 1 comment
Open

Add the enchanting "spells" as well as formulas? #18

kristianronningen opened this issue Jun 7, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@kristianronningen
Copy link

I just noticed now when building a list of professions for my guild, that the items that are really spells, are not present in data.json.

E.g. "Formula: Enchant Boots - Spirit" is present with itemId 16220, but "Enchant Boots - Spirit" with id 20024 is not. This also means I lose out on the very handy list of reagents. Enchanting is the only profession I checked, but there might be similar cases for other professions. Is it possible that this information can be added?

@Nakroma Nakroma added the enhancement New feature or request label Jun 28, 2021
@OkDruid
Copy link
Contributor

OkDruid commented Jul 30, 2022

Would be nice if this could be looked into for wotlk. Noticed this happens with many other items like leatherworking for armor kits. Would it be possible to retrieve all the craftable items from the profession spell tables and insert them into the matching items as I think all the spells include the reagent info but not all item id's do?

Example of the spell table filtered by profession which include all the reagent info:

https://www.wowhead.com/wotlk/spells/professions/

Edit: actually the leatherworking items that are missing reagents for crafting data are due to the current build not having been updated in a while as wowhead has the crafting data for those and running the build command again includes the missing crafting data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants