From 8f5c7e8b5b79aae08143549b21e78cc1dda2e56f Mon Sep 17 00:00:00 2001
From: "Aaron S. Brewster" <asbrewster@lbl.gov>
Date: Thu, 8 Feb 2024 10:57:55 -0800
Subject: [PATCH] Fix documentation of NXaperature (#1341)

- NXaperature was marked as deprecated but it is not, so fix the documentation
- Explicitly add an unammed NXoff_geometry field, the existence of which was implied by the GEOMETRY deprecation
---
 base_classes/NXaperture.nxdl.xml | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/base_classes/NXaperture.nxdl.xml b/base_classes/NXaperture.nxdl.xml
index 8277f3bfd2..63600255f2 100644
--- a/base_classes/NXaperture.nxdl.xml
+++ b/base_classes/NXaperture.nxdl.xml
@@ -27,7 +27,10 @@
     name="NXaperture" 
     type="group" extends="NXobject">
 
-    <doc>A beamline aperture. This group is deprecated, use NXslit instead.</doc>
+    <doc>
+      A beamline aperture.
+
+      Note, the group was incorrectly documented as deprecated, but it is not and it is in common use.</doc>
     <!-- TODO compare with "screens" in SHADOW -->
 
     <field name="depends_on" type="NX_CHAR">
@@ -56,6 +59,11 @@
         other component groups.
        </doc>
     </group>
+    <group type="NXoff_geometry">
+      <doc>
+        Use this group to describe the shape of the aperture
+      </doc>
+    </group>
     <group type="NXgeometry" deprecated="Use the field `depends_on` and :ref:`NXtransformations` to position the aperture and :ref:`NXoff_geometry` to describe its shape">
         <doc>
             location and shape of aperture