Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXenvironment #1451

Open
sanbrock opened this issue Sep 26, 2024 · 5 comments · May be fixed by #1414
Open

NXenvironment #1451

sanbrock opened this issue Sep 26, 2024 · 5 comments · May be fixed by #1414

Comments

@sanbrock
Copy link
Contributor

  • Can it be used as /ENTRY/INSTRUMENT/ENVIRONMENT or only /ENTRY/SAMPLE/ENVIRONMENT?
  • can an ENVIRONMENT list all independent controllers (for a scan) or only a single one?
  • can an ENVIRONMENT contain measurement sensors?
  • Also support parameters which may not be measured, like temperature could be simply RT (Room Temperature) without it being actually measured by a sensor.
@sanbrock sanbrock converted this from a draft issue Sep 26, 2024
@sanbrock
Copy link
Contributor Author

PR #1414

@lukaspie lukaspie linked a pull request Sep 29, 2024 that will close this issue
@sanbrock
Copy link
Contributor Author

Proposal:

  • use of @default
    A) add to each group manually as proposed
    B) no need to add, because it is a NeXus conventions that all groups can have this attribute
    C) add this to NXobject and let all group inherit it
  • NXidentifier
    A) use as a Base class which we add wherever needed
    B) make the Fields to Attributes and use this base class as super class. This allows attaching a single identifier to any group inheriting from this.
    C) same as B, but use nameType=partial, like identifier_serviceNAME, identifierNAME, and identifier_is_persistantNAME to support multiple IDs to add. E.g. identifier_experiment, identifier_collection, identifier_orcid, identifier_pdb
  • NXfabrication
    features: vendor, model(@Version), serial_number, construction_year, capability, IDENTIFIER
  • NXsensor
    added 'current' to the enum list of measurement types
    features FABRICATION
  • NXactuator
    features: (short)name, type, FABRICATION, physical_quantity, pid, OUTPUT, TRANSFORMATIONS
  • NXenvironment:
    added ACTUATOR
    added 'value' to support the case where no actual SENSOR, ACTUATOR is attached

@prjemian
Copy link
Contributor

prjemian commented Sep 29, 2024 via email

@phyy-nx
Copy link
Contributor

phyy-nx commented Sep 30, 2024

Use of default: B)
NXidentifier: instead of a new base class, NXidentifier, add to NXobject a set of identifier attributes. Useful for application definitions or for users wherever they want (like in #1486, but use attributes instead of a field
NXfabrication: ok following suggested edits
NXsensor: ok
NXactuator: ok following suggested edits
NXenvironment: ok

@phyy-nx
Copy link
Contributor

phyy-nx commented Sep 30, 2024

Proposal:

Use of default: B)
NXfabrication: ok following suggested edits
NXsensor: ok
NXactuator: ok following suggested edits
NXenvironment: ok

The above is approved by vote in NIAC 2024

Not for this proposal:
@sanbrock please provide an implementation of identifier as described above that we can vote on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To finish after the meeting
Development

Successfully merging a pull request may close this issue.

3 participants