Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXmx: should NXdetector_channel in NXdetector be required? #1511

Open
spc93 opened this issue Nov 14, 2024 · 1 comment
Open

NXmx: should NXdetector_channel in NXdetector be required? #1511

spc93 opened this issue Nov 14, 2024 · 1 comment
Assignees
@phyy-nx

Comments

@spc93
Copy link

spc93 commented Nov 14, 2024

This field probably doesn't make sense in many types of detector so would it be better to make it optional to avoid adding meaningless values or giving a validation error?
@spc93 spc93 mentioned this issue Nov 14, 2024
Closed
@phyy-nx
Copy link
Contributor

phyy-nx commented Jan 16, 2025

Telco: this looks like a bug. Will check with dectris then add recommended=True.

@phyy-nx phyy-nx self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phyy-nx phyy-nx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spc93 @phyy-nx