Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL2: Ensure modules config consistency: all modules have an ext.prefix and publishDir attribute, and follow conventions. #1066

Open
TCLamnidis opened this issue Apr 26, 2024 · 0 comments
Labels
Milestone

Comments

@TCLamnidis
Copy link
Collaborator

Best for publishDir to be explicitly on/off, and all modules (even when not publishing) need an ext.prefix, now that we don't have meta.id anymore.
Also ensure that all module configurations follow the code conventions (attribute order etc)

Results from quick check on 26/04/2024:

  • HOST_REMOVAL : has no ext.prefix
  • SAMTOOLS_INDEX_BAM_INPUT : has neither
  • SAMTOOLS_VIEW_GENOME: no ext.prefix
  • SAMTOOLS_INDEX_DAMAGE_RESCALED: no ext.prefix
  • SAMTOOLS_INDEX_DAMAGE_FILTERED: no ext.prefix
  • SAMTOOLS_INDEX_DAMAGE_TRIMMED: no ext.prefix
  • ANGSD_DOCOUNTS: wrong attribute order
  • MTNUCRATIO : no ext.prefix
  • QUALIMAP_BAMQC_WITHBED|QUALIMAP_BAMQC_NOBED: no ext.prefix
  • SAMTOOLS_DEPTH_SEXDETERRMINE: wrong attribute order
@TCLamnidis TCLamnidis added this to the 3.0 Augsburg milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant