Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxpasta only accepts a single taxonomy although multiple could be present in database samplesheet #293

Open
jfy133 opened this issue May 11, 2023 · 3 comments
Labels
bug Something isn't working enhancement Improvement for existing functionality

Comments

@jfy133
Copy link
Member

jfy133 commented May 11, 2023

Description of the bug

Theoretically a user could have a pipeline run that includes one database with e.g. a NCBI taxonomy, and one with a GTDB taxonomy.

Currently taxpasta merge only accepts a single taxonomy from a --param.

We should consider adding another (optional)( column to the database sheet that points to the corresponding tax dump files for each database.

Command used and terminal output

No response

Relevant files

No response

System information

No response

@jfy133 jfy133 added the bug Something isn't working label May 11, 2023
@jfy133 jfy133 added this to the 1.2.0 - Bouncy Basenji milestone May 11, 2023
@Midnighter
Copy link
Collaborator

Sigh you are perfectly right, of course.

@jfy133
Copy link
Member Author

jfy133 commented May 11, 2023

@jfy133
Copy link
Member Author

jfy133 commented Jun 20, 2023

In the meantime though we should document this (currently all databases are assumed to have the same taxonomy in usage md) and also that supplying the taxonomy dir is optional

@jfy133 jfy133 added the enhancement Improvement for existing functionality label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants