Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nextclade & pangolin modules #446

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Update nextclade & pangolin modules #446

merged 3 commits into from
Nov 8, 2024

Conversation

Joon-Klaps
Copy link

@Joon-Klaps Joon-Klaps commented Nov 5, 2024 •
edited
Loading

PR checklist

Nextclade & pangolin modules are getting outdated and were requested to be updated.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/viralrecon branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 406eb40

+| ✅ 201 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   9 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • system_exit - System.exit in nanopore.nf: System.exit(1) [line 246]

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-06 08:14:27

@Joon-Klaps
Copy link
Author

I'm trying to find when the --reference option for nextclade dataset get was removed. However, I've not been able to find it (yet). I therefore decided to remove the param --nextclade_dataset_reference which was the argument that got passed to --reference.

This was referenced Nov 5, 2024
Merged
Merged
@Joon-Klaps Joon-Klaps marked this pull request as ready for review November 5, 2024 12:10
svarona
svarona approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@svarona svarona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Joon-Klaps Joon-Klaps merged commit 27b2c6c into nf-core:dev Nov 8, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svarona svarona svarona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joon-Klaps @svarona