-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcoded CARD_WIDTH #4
Comments
May I ask what CARD_WIDTH meas? |
Do you mean this |
|
I nearly get it.Should we dynamically compute it by screen width or something else? |
@DawnMagnet I suppose we should be able to compute it based on screen width? Maybe we can introduce a max card width computable from screen width? The more complicated part of the story is that, the height of the card is defined as a fixed ratio of its width. So adjusting card width can also change the amount of vertical screen space occupied by a card, affecting the layout and animation of the card detail fields below the card. I guess it's not a big problem, but we should be careful about that. |
CARD_WIDTH should be computed dynamically.
@CircuitCoder
The text was updated successfully, but these errors were encountered: