Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate unique names #22

Open
nfroidure opened this issue May 24, 2022 · 0 comments
Open

Generate unique names #22

nfroidure opened this issue May 24, 2022 · 0 comments
Assignees
@nfroidure
Labels
enhancement New feature or request

Comments

@nfroidure
Copy link
Owner

Sometimes the buildIdentifier function leads to the same identifier for two different values. We could add into the context a "buildAndReserveIdentifier" to create all new identifiers and ensure they are unique. Alternatively we could just throw if the identifier lead to an already generated name. Namespaces could be taken in count to avoid being too restritive.
@nfroidure nfroidure added the enhancement New feature or request label May 24, 2022
@nfroidure nfroidure self-assigned this May 24, 2022
nfroidure added a commit that referenced this issue May 24, 2022
@nfroidure
fix(types): avoid generating empty identifiers
2b5d554 
concerns #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfroidure nfroidure

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nfroidure