Skip to content
This repository has been archived by the owner on Jul 11, 2018. It is now read-only.

ngui/overlay on old Firefox 16.0.2 #29

Open
boom235 opened this issue Jun 13, 2017 · 1 comment
Open

ngui/overlay on old Firefox 16.0.2 #29

boom235 opened this issue Jun 13, 2017 · 1 comment

Comments

@boom235
Copy link

boom235 commented Jun 13, 2017

Hey there,
I am using ngui/overlay with my angular2 app, which works great! Thanks a lot!

Now I need to fulfill compatibilty for an old Firefox LTS version (16.0.2). Angular2 and alle other modules I use do not make any bigger problems. At least after a few compatibility fixes.

Unfortunately ngui/overlay does not work anymore. The overlay stays in display:none even after opening. With that Firefox I cannot even open the examples on the official example page. I do not get any errors with Firebug.

Is there a way to fix this? Or are older browsers just not supported and I need to program this myself? Angular 4.0.0 is running with that browser.

Thanks in advance!
Fabian

@boom235
Copy link
Author

boom235 commented Jun 13, 2017

hm, I just found out, Firefox does only support "display:flex" from version 28 on.... This is why. When I change the display style to block and do the positioning myself, everything works just fine.

NOT BEAUTIFUL but a quick solution for the moment is the following code, after opening the Overlay:
`this.overlayManager.open('my-overlay', event);

    /** begin Firefox 16.0.2 FIX */
    let overlayEl = document.getElementsByTagName('ngui-overlay')[0];
    let styleAttributes = overlayEl.getAttribute('style');
    overlayEl.setAttribute('style', styleAttributes+'display: block');
    /** end Firefox 16.0.2 FIX */`

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant