Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ng2-overlay should probably be a normal dependency #4

Open
seiyria opened this issue Feb 26, 2017 · 2 comments
Open

ng2-overlay should probably be a normal dependency #4

seiyria opened this issue Feb 26, 2017 · 2 comments
Labels
Implemented & Pending Validation

Comments

@seiyria
Copy link

seiyria commented Feb 26, 2017

otherwise a user has to install it themselves
@allenhwkim
Copy link
Contributor

@seiyria thanks for reporting it. I will make a change soon.

allenhwkim added a commit that referenced this issue Feb 27, 2017
@allenhwkim
issue #4, #5 refactoring by including ng2-overlay as a cdpendency and…
0b6be11 
… changed directive to component
@allenhwkim
Copy link
Contributor

0.4.1 released with the required changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Implemented & Pending Validation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seiyria @allenhwkim