-
Notifications
You must be signed in to change notification settings - Fork 113
Add support for RequestMirror filter #3306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3306 +/- ##
==========================================
+ Coverage 86.16% 86.20% +0.04%
==========================================
Files 113 116 +3
Lines 11664 11928 +264
Branches 62 62
==========================================
+ Hits 10050 10283 +233
- Misses 1553 1580 +27
- Partials 61 65 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
63572c7
to
c4c62ce
Compare
Do we have something tracking this? Other than that, nice work! 🚀 |
@ciarams87 I was planning on adding it as acceptance criteria to the 1.3 story when we create that |
a802d7c
to
b5daf3e
Compare
Problem: As a user, I want to be able to mirror requests to another backend(s) using the RequestMirror filter on an HTTPRoute or GRPCRoute. Solution: Add support for the RequestMirror filter, allowing users to mirror requests with HTTPRoutes or GRPCRoutes.
b5daf3e
to
0b0bec8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🚀
Problem: As a user, I want to be able to mirror requests to another backend(s) using the RequestMirror filter on an HTTPRoute or GRPCRoute.
Solution: Add support for the RequestMirror filter, allowing users to mirror requests with HTTPRoutes or GRPCRoutes.
Testing: Manually verified single mirror filter, multiple mirror filter, mirror filter with other filters.
Note: the RequestMirror conformance tests seem to have a bug in 1.2.1 Gateway API, which may be fixed in 1.3. We can hopefully enable them at that point.
Closes #533
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.