Skip to content

Commit 9f1d738

Browse files
http: Compress application responses
Co-authored-by: Alejandro Colomar <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]> Signed-off-by: Andrew Clayton <[email protected]>
1 parent 84a19b0 commit 9f1d738

File tree

4 files changed

+96
-1
lines changed

4 files changed

+96
-1
lines changed

Diff for: src/nxt_http_compression.c

+81
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,57 @@ nxt_http_comp_bound(size_t size)
181181
}
182182

183183

184+
nxt_int_t
185+
nxt_http_comp_compress_app_response(nxt_http_request_t *r)
186+
{
187+
bool last;
188+
size_t buf_len, in_len;
189+
ssize_t cbytes;
190+
nxt_buf_t *buf, *b = r->out;
191+
nxt_http_comp_ctx_t *ctx = &compressor_ctx;
192+
193+
printf("%s: \n", __func__);
194+
195+
if (ctx->idx == NXT_HTTP_COMP_SCHEME_IDENTITY) {
196+
printf("%s: NXT_HTTP_COMP_SCHEME_IDENTITY [skipping/identity]\n",
197+
__func__);
198+
return NXT_OK;
199+
}
200+
201+
if (b->mem.pos == NULL) {
202+
return NXT_OK;
203+
}
204+
205+
in_len = b->mem.free - b->mem.pos;
206+
207+
last = !b->next || b->next->is_last == 1;
208+
209+
buf_len = nxt_http_comp_bound(in_len);
210+
211+
buf = nxt_buf_mem_alloc(r->mem_pool, buf_len, 0);
212+
if (nxt_slow_path(buf == NULL)) {
213+
return NXT_ERROR;
214+
}
215+
216+
nxt_memcpy(buf, b, offsetof(nxt_buf_t, mem));
217+
buf->data = r->mem_pool;
218+
219+
cbytes = nxt_http_comp_compress(b->mem.pos, in_len, buf->mem.start,
220+
buf->mem.end - buf->mem.start, last);
221+
printf("%s: cbytes = %ld\n", __func__, cbytes);
222+
if (cbytes == -1) {
223+
return NXT_ERROR;
224+
}
225+
226+
// if (cbytes != -1) {
227+
// b->mem.free = nxt_cpymem(b->mem.pos, tmp->mem.start, cbytes);
228+
// }
229+
b = buf;
230+
231+
return NXT_OK;
232+
}
233+
234+
184235
nxt_int_t
185236
nxt_http_comp_compress_static_response(nxt_task_t *task, nxt_file_t **f,
186237
nxt_file_info_t *fi,
@@ -400,6 +451,14 @@ nxt_http_comp_set_header(nxt_http_request_t *r, nxt_uint_t comp_idx)
400451
static const nxt_str_t content_encoding_str =
401452
nxt_string("Content-Encoding");
402453

454+
printf("%s: \n", __func__);
455+
456+
#if 0
457+
if (comp_idx == NXT_HTTP_COMP_SCHEME_IDENTITY) {
458+
return NXT_OK;
459+
}
460+
#endif
461+
403462
f = nxt_list_add(r->resp.fields);
404463
if (nxt_slow_path(f == NULL)) {
405464
return NXT_ERROR;
@@ -414,6 +473,28 @@ nxt_http_comp_set_header(nxt_http_request_t *r, nxt_uint_t comp_idx)
414473
f->value = token->start;
415474
f->value_length = token->length;
416475

476+
r->resp.content_length = NULL;
477+
r->resp.content_length_n = -1;
478+
479+
if (r->resp.mime_type == NULL) {
480+
nxt_http_field_t *f;
481+
482+
/*
483+
* As per RFC 2616 section 4.4 item 3, you should not send
484+
* Content-Length when a Transfer-Encoding header is present.
485+
*/
486+
nxt_list_each(f, r->resp.fields) {
487+
if (nxt_strcasecmp(f->name,
488+
(const u_char *)"Content-Length") == 0)
489+
{
490+
printf("%s: Found (%s: %s), marking as 'skip'\n", __func__,
491+
f->name, f->value);
492+
f->skip = true;
493+
break;
494+
}
495+
} nxt_list_loop;
496+
}
497+
417498
return NXT_OK;
418499
}
419500

Diff for: src/nxt_http_compression.h

+1
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ extern const nxt_http_comp_operations_t nxt_comp_brotli_ops;
9191
#endif
9292

9393

94+
extern nxt_int_t nxt_http_comp_compress_app_response(nxt_http_request_t *r);
9495
extern nxt_int_t nxt_http_comp_compress_static_response(nxt_task_t *task,
9596
nxt_file_t **f, nxt_file_info_t *fi, size_t static_buf_len,
9697
size_t *out_total);

Diff for: src/nxt_port_queue.h

+2
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ nxt_port_queue_recv(nxt_port_queue_t volatile *q, void *p)
8181
nxt_nncq_atomic_t i;
8282
nxt_port_queue_item_t *qi;
8383

84+
// printf("%s \n", __func__);
85+
8486
i = nxt_nncq_dequeue(&q->queue);
8587
if (i == nxt_nncq_empty(&q->queue)) {
8688
return -1;

Diff for: src/nxt_router.c

+12-1
Original file line numberDiff line numberDiff line change
@@ -4136,6 +4136,8 @@ nxt_router_response_ready_handler(nxt_task_t *task, nxt_port_recv_msg_t *msg,
41364136
nxt_unit_response_t *resp;
41374137
nxt_request_rpc_data_t *req_rpc_data;
41384138

4139+
printf("%s: \n", __func__);
4140+
41394141
req_rpc_data = data;
41404142

41414143
r = req_rpc_data->request;
@@ -4191,8 +4193,11 @@ nxt_router_response_ready_handler(nxt_task_t *task, nxt_port_recv_msg_t *msg,
41914193

41924194
if (r->header_sent) {
41934195
nxt_buf_chain_add(&r->out, b);
4194-
nxt_http_request_send_body(task, r, NULL);
41954196

4197+
/* XXX Do compression here */
4198+
nxt_http_comp_compress_app_response(r);
4199+
4200+
nxt_http_request_send_body(task, r, NULL);
41964201
} else {
41974202
b_size = nxt_buf_is_mem(b) ? nxt_buf_mem_used_size(&b->mem) : 0;
41984203

@@ -4272,6 +4277,12 @@ nxt_router_response_ready_handler(nxt_task_t *task, nxt_port_recv_msg_t *msg,
42724277
nxt_buf_chain_add(&r->out, b);
42734278
}
42744279

4280+
/* XXX Check compression / modify headers here */
4281+
ret = nxt_http_comp_check_compression(task, r);
4282+
if (ret != NXT_OK) {
4283+
goto fail;
4284+
}
4285+
42754286
nxt_http_request_header_send(task, r, nxt_http_request_send_body, NULL);
42764287

42774288
if (r->websocket_handshake

0 commit comments

Comments
 (0)