Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Broken UI in user page #1175

Closed
3 tasks done
devAlisha opened this issue Nov 26, 2023 · 9 comments
Closed
3 tasks done

Bug: Broken UI in user page #1175

devAlisha opened this issue Nov 26, 2023 · 9 comments
Assignees
Labels
🐞 bug This is a patch, generally fixing some bugs. invite me to the organisation Sends an invitation to your community organisation. status: wip 👩🏻‍💻 This issue/PR is actively being worked on.

Comments

@devAlisha
Copy link

devAlisha commented Nov 26, 2023

Description

When resizing the screen on the User page, the carousel images for Events Attending overlap, leading to a visual issue that negatively impacts the user experience. This issue requires attention and resolution.

Steps to Reproduce

  1. Visit the User page by navigating to /User/:userId.
  2. Ensure the initial screen size is set to 1440px.
  3. Gradually reduce the screen size to a smaller resolution.
  4. Observe the carousel images and note the overlap.

Proposed Solution

Using window.innerWidth in combination with the resize event listener and React state

Screenshots

image

Browser 🥦

Google Chrome

Checklist ✅

@devAlisha devAlisha added hacktoberfest This issue is a part of hacktoberfest 2023. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Nov 26, 2023
@github-project-automation github-project-automation bot moved this to Todo in Milan Nov 26, 2023
Copy link

Hello @devAlisha, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this issue is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@devAlisha
Copy link
Author

I'm willing to work on this issue
Please assign this to me

@devAlisha devAlisha changed the title Bug: Write a small description here Bug: Broken UI in user page Nov 26, 2023
@chinmayborade
Copy link

I am interested to work on this

@tamalCodes
Copy link
Member

tamalCodes commented Nov 30, 2023

Hi @devAlisha , as you said about the overlapping part, how about we do a slider because if you look at this line here, you will notice that the data is just fixed which also causes responsiveness issue sometimes.

A club might also do 10-15 events, so I assume a slider would be better.
If you look at the mentor's section, this would be a great example of what i want. You can start working on it too.

📑 Checklist in case you missed something

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

@tamalCodes tamalCodes added status: wip 👩🏻‍💻 This issue/PR is actively being worked on. and removed hacktoberfest This issue is a part of hacktoberfest 2023. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Nov 30, 2023
@tamalCodes tamalCodes moved this from Todo to In Progress (Issues) in Milan Nov 30, 2023
@devAlisha
Copy link
Author

In the code we are already using a slider just like the mentor section
when the screen size is <1200 then it is supposed to just show 1 card in that swiper but that is not working because we should use useEffect and useState along with event listener
Furthur, to improve the performance we can use window.matchMedia as it provides better performance
Please, share your views on this

@devAlisha
Copy link
Author

There is a better, easier solution
swiper library that we are using also provides the breakpoints attribute
image
We can simply use this in both the pages (userProfile and clubProfile)
Should I implement this @tamalCodes ?

@devAlisha
Copy link
Author

I've raised the PR please do review @tamalCodes
Also, I've added pagination attribute from the swiper library because at the first glance it looked like event were cards instead of a slider

@Salonijain2210
Copy link

Please allow me the opportunity to resolve this issue at hand

@github-project-automation github-project-automation bot moved this from In Progress (Issues) to Merged/Discarded in Milan Jan 11, 2024
@tamalCodes tamalCodes added the invite me to the organisation Sends an invitation to your community organisation. label Mar 12, 2024
Copy link

Hi @tamalCodes, We just made a new organization, and have sent you an invite. Welcome to the community 🎉

Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/MilanCommunity/people

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug This is a patch, generally fixing some bugs. invite me to the organisation Sends an invitation to your community organisation. status: wip 👩🏻‍💻 This issue/PR is actively being worked on.
Projects
Status: Merged/Discarded
Development

Successfully merging a pull request may close this issue.

4 participants