Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling for filter_dob function #42

Open
steven-buckley opened this issue May 16, 2023 · 0 comments
Open

Error handling for filter_dob function #42

steven-buckley opened this issue May 16, 2023 · 0 comments

Comments

@steven-buckley
Copy link
Collaborator

At the moment the filter_dob applies some logic to limit the joins based on the number of matching characters in the dob string.

However, this is tailored towards the formatted date of birth output from the filter_dob function.

If somebody calls the matching function without applying the formatting, some warning messages may be outputted to the console.

These typically seem to occur when the dob string includes non-numeric characters and the function is trying to convert these to integers and having to switch to NA instead. This means one of the additional options for comparing dates is skipped due to lack of relevant information but the warning message is not clear that this is what has happened.

Could either handle the warning message or revise function to handle unformatted strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant