Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR build's virtualenv caching does not handle file dependencies like ../../packages/service correctly #941

Open
bkeryan opened this issue Sep 25, 2024 · 0 comments
Labels
tech debt Non-user-visible improvement to code or development process triage New issue that needs to be reviewed

Comments

@bkeryan
Copy link
Collaborator

bkeryan commented Sep 25, 2024

Tech Debt

The PR build uses actions/cache to cache virtualenvs based on the hash of poetry.lock. For external dependencies, this works great, but when using file dependencies to reference other packages in the same repo such as ../../packages/service, this doesn't work right because the contents of ../../packages/service are not reflected in the hash of poetry.lock.

Workarounds:

  • Use develop = true to avoid copying local packages to the venv
  • Modify poetry.lock when making changes to code
  • Use the GitHub Actions tab to delete the cache.

AB#2867348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Non-user-visible improvement to code or development process triage New issue that needs to be reviewed
Projects
None yet
Development

No branches or pull requests

1 participant