Use timing and levels sheets name when applying rather than path #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Mendez <[email protected]>
jonathanmendez
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
bkeryan
approved these changes
Jun 7, 2023
mshafer-NI
reviewed
Jun 8, 2023
bkeryan
approved these changes
Jun 8, 2023
Signed-off-by: Jonathan Mendez <[email protected]>
Signed-off-by: Jonathan Mendez <[email protected]>
jonathanmendez
force-pushed
the
users/jomendez/load-sheets-by-name
branch
from
839489b
to
b844fdb
Compare
|
I revalidated the fix after my latest changes. Completing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Fixes Issue #259
The apply_levels_and_timing API allows the use of the file name (without extension) or the use of an absolute path. Since the file names are passed in as relative paths, while it is necessary to resolve to an absolute path if calling
load_specifications_levels_and_timing, the name can be used when callingapply_levels_and_timing. This allows for when the files have been loaded from a different location at session initialization time, as is the case with the TestStand sequence.Why should this Pull Request be merged?
Make the nidigital_spi example work in cases where the TestStand sequence initializes the session with files that are found in a different location than next to the measurement service.
What testing has been done?
Followed the steps to reproduce before the fix to see the error. Followed the steps to reproduce after the fix to see the sequence pass.