Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox 4.0+ expects allowlist_externals instead of whitelist_externals #1882

Closed
tobiasgordon opened this issue Dec 16, 2022 · 0 comments · Fixed by #1912
Closed

tox 4.0+ expects allowlist_externals instead of whitelist_externals #1882

tobiasgordon opened this issue Dec 16, 2022 · 0 comments · Fixed by #1912
Assignees
Labels

Comments

@tobiasgordon
Copy link
Collaborator

Description of issue

When running `tox`, if using version 4.0 or newer, several `make` steps will fail because `tox.ini` is missing `allowlist_externals`. This field was added in `tox` 3.18.0 and `whitelist_externals` deprecated. `whitelist_externals` was removed completely in `tox` 4.0.

Steps to reproduce issue

1. Install `tox` 4.0 or later.
2. Run `tox` on the `nimi-python` project

This will give errors like:

$ tox -e clean;
clean: commands[0] .> python --version
Python 3.10.9
clean: commands[1] .> python -c 'import platform; print(platform.architecture())'
('64bit', 'ELF')
clean: commands[2] .> make clean
clean: failed with make is not allowed, use allowlist_externals to allow it
  clean: FAIL code 1 (0.08 seconds)
  evaluation failed :( (0.25 seconds)
@tobiasgordon tobiasgordon self-assigned this Dec 16, 2022
@ni-jfitzger ni-jfitzger linked a pull request May 5, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants