Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nyaa 'Stub!' message on compatible apps #18

Open
7 tasks done
rockisch opened this issue Jan 7, 2025 · 4 comments
Open
7 tasks done

Nyaa 'Stub!' message on compatible apps #18

rockisch opened this issue Jan 7, 2025 · 4 comments

Comments

@rockisch
Copy link

rockisch commented Jan 7, 2025

Source information

Nyaa (Torrent) 14.1

Source language

Multi

Steps to reproduce

  1. Install Nyaa extension on either Aniyomi, Kuukiyomi or Animetail
  2. Access the extension repository
  3. Try opening any entry

Expected behavior

I should be able to see the video entry

Actual behavior

A 'Stub!' toast is triggered

Aniyomi version

0.16.4.3

Android version

14

Other details

Probably related to #9, but even when I tried the last released version of Kuukiyomi I got the same error message. The same also happened with the latest version of Animetail (which supposedly also has torrent support).

My understanding is that Kuukiyomi's torrenting feature was going to get merged into Aniyomi, but I'm not sure what's the status of that currently.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have updated the app to version 0.15.2.4.
  • I have updated all installed extensions.
  • I have tried the troubleshooting guide.
  • If this is an issue with the app itself, I should be opening an issue in the app repository.
  • I will fill out all of the requested information in this form.
@rockisch
Copy link
Author

rockisch commented Jan 7, 2025

Ok so, I took a look at the code and it seems like the extension was designed so it would split torrents with multiple files into separate episodes, but I guess that was never implemented?
https://github.com/ni3x/aniyomi-extensions/blob/master/src/all/nyaatorrent/src/eu/kanade/tachiyomi/torrentutils/TorrentUtils.kt

I just did some testings on my machine with Animetail, and treating an SAnime as containing a single SEpisode with the magnet link as the video URL seems to work out of the box for torrents with a single video. Even when the torrent has multiple files, the player plays the first video and then stops.

I could either send the changes I made as a fix, or work to do the splitting of entries, but I'm not sure if that would even work. Maybe using something like https://superuser.com/a/1846742

@ni3x
Copy link
Owner

ni3x commented Jan 15, 2025

Currently Aniyomi do not support torrent, Nyaa only works with Kuukiyomi for now. Need to update torrent lib so it can support Animetail.

@lalalasupa0
Copy link

lalalasupa0 commented Jan 21, 2025

Currently Aniyomi do not support torrent, Nyaa only works with Kuukiyomi for now. Need to update torrent lib so it can support Animetail.

Is it still an issue with Animetail and not with the extension as said before?
I opened an issue on the Animetail repo hoping they would do something about it, and recently it seems they did update something from Kuuki, but I'm not sure if it was what caused this Stub! thing
If it is now an issue with the extension then I'll close that issue

@rockisch
Copy link
Author

Nyaa only works with Kuukiyomi for now

That's weird, I tried running it with the latest Kuukiyomi version as well and it threw the same message.

I'm not really an Android developer, but I would imagine the import eu.kanade.tachiyomi.torrentutils.TorrentUtils import will always import the stub version instead of the one provided by the app if it's defined, no? Again, maybe that's not how it works.

Regardless, I later found out there's already a torrent PR for Aniyomi inspired in Kuukiyomi's implementation, so prob better wait until that is merged before doing anything:
aniyomiorg/aniyomi#1620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants