New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow 172.16. .... and 10. ... ip address ranges #6

Open

niccokunzmann opened this issue Apr 8, 2016 · 3 comments

Owner

niccokunzmann commented Apr 8, 2016

the address ranges should be fully exploitable

Contributor

vitormhenrique commented Dec 28, 2018

Nicco, do you remember where in the code this limitation exists? I'll try to fix this... not really sure if I'll be capable but...

Owner Author

niccokunzmann commented Dec 28, 2018

https://github.com/niccokunzmann/python_dhcp_server/blob/master/server/dhcp.py#L182
https://github.com/niccokunzmann/python_dhcp_server/blob/master/server/dhcp.py#L462
https://github.com/niccokunzmann/python_dhcp_server/blob/master/server/dhcp.py#L481
https://github.com/niccokunzmann/python_dhcp_server/blob/master/server/dhcp.py#L262
https://github.com/niccokunzmann/python_dhcp_server/blob/master/server/dhcp.py#L227

To me it seems like the address ranges should be fully usable from this code.

However, I read this:

https://github.com/niccokunzmann/python_dhcp_server/blob/master/server/dhcpgui.conf#L22

this line only skips the first 5.

https://github.com/niccokunzmann/python_dhcp_server/blob/master/server/dhcp.py#L255

So, the range can not be changed directly but it rather fills the subnet mask range.

Owner Author

niccokunzmann commented Dec 28, 2018

I think, this can be closed because the issue is gone. But, if you like, you can check. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment