Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default, Uncompressing Harbor installer is skipped #3

Open
ghost opened this issue Mar 19, 2019 · 2 comments
Open

By default, Uncompressing Harbor installer is skipped #3

ghost opened this issue Mar 19, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Mar 19, 2019

When you first run the role you get:

TASK [ Uncompressing Harbor installer...] ************************************************
skipping: [test_server]

That is probably because unarchive sees that {{ harbor_install_dir }}/harbor already exists. It is created by

- name: "Creating Harbor directory... ({{ harbor_install_dir }}/harbor)"
  file: ...
@ghost ghost changed the title By default, Unc By default, Uncompressing Harbor installer is skipped Mar 19, 2019
@nicholasamorim
Copy link
Owner

So here's a question, what would be an effective way to check if Harbor is installed?

Technically, we could check folder, files inside the folder or if the docker image exist. But none of these strike me as particularly solid. Or we shouldn't check that and just override whatever is there?

Suggestions?

@ghost
Copy link
Author

ghost commented Mar 19, 2019

Removing the /harbor in

path: "{{ harbor_install_dir }}"
was a quick fix but yes it would be good that it's more solid.
If there is no customization or data in the direction (which I don't think there is), overriding could be good. It's probably good in general if you want your infra "compliant" to what you set with the script so for other things EXCEPT the ssl certificate (for example, in my case I use my own and don't want it disappearing :D), it might be good to overwrite. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant