Move SSL settings to separate config files #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each entry in nginx_sites, create a file at /etc/nginx/conf.d/common_ssl_site.domains[0].conf containing its SSL configs, and include that in its main configuration files. This should fix upstream Issue #15. Also create /etc/nginx.conf.d/common_ssl_default.conf with the default SSL settings. This is convenient for other vhosts -- including those not managed by this role -- to be able to import.
I forgot the /etc/nginx/conf.d/ dir is included by the main nginx.conf file. Store configuration snippets in our own directory (/etc/nginx/ansible-nginx-conf.d) instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each entry in
nginx_sites, create a file at/etc/nginx/conf.d/common_ssl_site.<domain>.confcontaining its SSLconfigs, and include that in its main configuration files. This should
fix upstream Issue #15.
Also create
/etc/nginx.conf.d/common_ssl_default.confwith the defaultSSL settings. This is convenient for other vhosts -- including those not
managed by this role -- to be able to import.