Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location of STLSpecificationParser #91

Closed
TomyYamy opened this issue Jan 11, 2022 · 2 comments
Closed

location of STLSpecificationParser #91

TomyYamy opened this issue Jan 11, 2022 · 2 comments
Assignees

Comments

@TomyYamy
Copy link
Collaborator

I think current location
rtamt/rtamt/ast/parser/stl/discrete_time/specification_parser.py
in
commit: c2b6dbd branch ast-refactoring
is pretty good. But let's keep in mind.

@TomyYamy
Copy link
Collaborator Author

I would like to change the structure a little bit.
Please see, my commit: 5f7d5a8 branch STLSpecificationParser.
I find we have
rtamt/rtamt/ast/parser/stl/discrete_time/specification_parser.py
rtamt/rtamt/ast/parser/stl/dense_time/specification_parser.py
and main implantation done in discrete_time and dense_time overwrite only visitConstantTimeLiteral().

regarding #6
2. extend a few operator to existed TL (like STL).
some library use want to implement only dense_time. The code gives misunderstanding we need to implement discrete_time in any case. However, in reality, discrete_time or dense_time only effect visitConstantTimeLiteral() and others are common.
In that sense, my suggestion is,
rtamt/rtamt/ast/parser/stl/specification_parser.py : put almost of all method
rtamt/rtamt/ast/parser/stl/discrete_time/specification_parser.py : discrete_time version of visitConstantTimeLiteral()
rtamt/rtamt/ast/parser/stl/dense_time/specification_parser.py : dense_time version visitConstantTimeLiteral()

I did not give pull-request. I did not check it works or not because of luck of issue #89

@TomyYamy
Copy link
Collaborator Author

I merged the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants