Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of ROS specific annotations #99

Open
TomyYamy opened this issue Jan 25, 2022 · 5 comments
Open

Location of ROS specific annotations #99

TomyYamy opened this issue Jan 25, 2022 · 5 comments

Comments

@TomyYamy
Copy link
Collaborator

This relates #97.
We are supporting ROS.

publish_var : String - variable name to be published
publish_var_field : String - variable field to be published

It is in spec layer.

@TomyYamy
Copy link
Collaborator Author

@nickovic
Still I feel we may remains it in spec. rather than AST or semantics.

@TomyYamy
Copy link
Collaborator Author

I find at least, AbstractParserVisitor does not support it. It is good.

@TomyYamy
Copy link
Collaborator Author

TomyYamy commented Jan 27, 2022

Sorry I find somehow AST relates subscribe, publish potentially in our refactoring code.
Please see commit: 5c2e95c branch: ast-refactoring-trial
rtamt/rtamt/ast/parser/abstract_ast_paser.py
declare_var() has

self.var_topic_dict[var_name] = 'rtamt/{}'.format(var_name)

Perhaps we may move it some where.

@TomyYamy TomyYamy changed the title Location of ROS specific data in parse phase Location of ROS specific annotations Feb 1, 2022
@TomyYamy
Copy link
Collaborator Author

TomyYamy commented Feb 1, 2022

Perhaps we may move it rtamt4ros?

@TomyYamy
Copy link
Collaborator Author

TomyYamy commented Feb 8, 2022

I find ANTRL parser is handing ros topic too.

ROS_Topic
: 'topic' ;

I know what we do here. I know it is difficult to transfer ROS annotation to rtamt4ros.
Maybe here is discussion point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants