Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "broken symlink as an input the ShellTask" #4

Open
wants to merge 2 commits into
base: skip_symlink_hash
Choose a base branch
from

Conversation

nicolocin
Copy link
Owner

Reverts #3 - messed up local git, will add later

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #4 into skip_symlink_hash will decrease coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           skip_symlink_hash       #4      +/-   ##
=====================================================
- Coverage              86.95%   86.54%   -0.41%     
=====================================================
  Files                     20       20              
  Lines                   3349     3352       +3     
  Branches                 891      891              
=====================================================
- Hits                    2912     2901      -11     
- Misses                   272      287      +15     
+ Partials                 165      164       -1     
Flag Coverage Δ
#unittests 86.54% <100.00%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/helpers.py 86.50% <100.00%> (+0.34%) ⬆️
pydra/engine/helpers_file.py 85.29% <100.00%> (+5.29%) ⬆️
pydra/conftest.py 77.77% <0.00%> (-22.23%) ⬇️
pydra/engine/workers.py 77.61% <0.00%> (-6.97%) ⬇️
pydra/utils/profiler.py 38.16% <0.00%> (-5.35%) ⬇️
pydra/engine/submitter.py 90.51% <0.00%> (-1.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07b20bf...76b144c. Read the comment docs.

nicolocin pushed a commit that referenced this pull request Dec 23, 2020
Merging the most updated pydra with my forked version of the repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant